feat: improve performance of matrix when multiple selectors are specified #631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is practically un-reviewable, as I have re-written and refactored large chunks of the matrix code, for both performance and readability reasons. It had to be done however, and I'm pleased with the results.
Things worth noting:
Performance optimisation
--cpu-period=100000 --cpu-quota=50000
, because my dev machine has way more CPU than our prod database, and the queries would otherwise run practically instantaneously.Refactoring