test: add more tests to cover the changes

cmd/gtk/dialog_transaction_bond.go

@@ -83,25 +83,10 @@ To: <b>%v</b>
 Amount: <b>%v</b>
 Fee: <b>%v</b>
 
-	THIS ACTION IS NOT REVERSIBLE Do you want to continue?`, sender, receiver,
+THIS ACTION IS NOT REVERSIBLE. Do you want to continue?`, sender, receiver,
 			util.ChangeToString(amount), util.ChangeToString(trx.Fee()))
 
-		if showQuestionDialog(dlg, msg) {
-			password, ok := getWalletPassword(wallet)
-			if !ok {
-				return
-			}
-			err := wallet.SignTransaction(password, trx)
-			if err != nil {
-				errorCheck(err)
-				return
-			}
-			_, err = wallet.BroadcastTransaction(trx)
-			if err != nil {
-				errorCheck(err)
-				return
-			}
-		}
+		signAndBroadcastTransaction(dlg, msg, wallet, trx)
 
 		dlg.Close()
 	}

cmd/gtk/dialog_transaction_send.go

@@ -73,25 +73,10 @@ To: <b>%v</b>
 Amount: <b>%v</b>
 Fee: <b>%v</b>
 
-	THIS ACTION IS NOT REVERSIBLE Do you want to continue?`, sender, receiver,
+THIS ACTION IS NOT REVERSIBLE. Do you want to continue?`, sender, receiver,
 			util.ChangeToString(amount), util.ChangeToString(trx.Fee()))
 
-		if showQuestionDialog(dlg, msg) {
-			password, ok := getWalletPassword(wallet)
-			if !ok {
-				return
-			}
-			err := wallet.SignTransaction(password, trx)
-			if err != nil {
-				errorCheck(err)
-				return
-			}
-			_, err = wallet.BroadcastTransaction(trx)
-			if err != nil {
-				errorCheck(err)
-				return
-			}
-		}
+		signAndBroadcastTransaction(dlg, msg, wallet, trx)
 
 		dlg.Close()
 	}

cmd/gtk/utils.go

@@ -8,6 +8,7 @@ import (
 
 	"github.com/gotk3/gotk3/glib"
 	"github.com/gotk3/gotk3/gtk"
+	"github.com/pactus-project/pactus/types/tx"
 	"github.com/pactus-project/pactus/util"
 	"github.com/pactus-project/pactus/wallet"
 )
@@ -178,3 +179,28 @@ func updateHintLabel(lbl *gtk.Label, hint string) {
 	lbl.SetMarkup(
 		fmt.Sprintf("<span foreground='gray' size='small'>%s</span>", hint))
 }
+
+func signAndBroadcastTransaction(parent *gtk.Dialog, msg string, w *wallet.Wallet, trx *tx.Tx) {
+	if showQuestionDialog(parent, msg) {
+		password, ok := getWalletPassword(w)
+		if !ok {
+			return
+		}
+		err := w.SignTransaction(password, trx)
+		if err != nil {
+			errorCheck(err)
+			return
+		}
+		_, err = w.BroadcastTransaction(trx)
+		if err != nil {
+			errorCheck(err)
+			return
+		}
+
+		err = w.Save()
+		if err != nil {
+			errorCheck(err)
+			return
+		}
+	}
+}

crypto/address_test.go

@@ -9,6 +9,16 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+func TestAddressKeyEqualsTo(t *testing.T) {
+	addr1 := GenerateTestAddress()
+	addr2 := GenerateTestAddress()
+
+	assert.True(t, addr1.EqualsTo(addr1))
+	assert.False(t, addr1.EqualsTo(addr2))
+	assert.Equal(t, addr1, addr1)
+	assert.NotEqual(t, addr1, addr2)
+}
+
 func TestFingerprint(t *testing.T) {
 	addr1 := GenerateTestAddress()
 	assert.Contains(t, addr1.String(), addr1.Fingerprint())

crypto/bls/private_key_test.go

@@ -9,6 +9,16 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+func TestPrivateKeyEqualsTo(t *testing.T) {
+	_, prv1 := GenerateTestKeyPair()
+	_, prv2 := GenerateTestKeyPair()
+
+	assert.True(t, prv1.EqualsTo(prv1))
+	assert.False(t, prv1.EqualsTo(prv2))
+	assert.Equal(t, prv1, prv1)
+	assert.NotEqual(t, prv1, prv2)
+}
+
 func TestPrivateKeyToString(t *testing.T) {
 	tests := []struct {
 		errMsg  string

crypto/bls/public_key_test.go

@@ -28,6 +28,16 @@ func TestPublicKeyCBORMarshaling(t *testing.T) {
 	assert.Error(t, pub2.UnmarshalCBOR(data))
 }
 
+func TestPublicKeyEqualsTo(t *testing.T) {
+	pub1, _ := GenerateTestKeyPair()
+	pub2, _ := GenerateTestKeyPair()
+
+	assert.True(t, pub1.EqualsTo(pub1))
+	assert.False(t, pub1.EqualsTo(pub2))
+	assert.Equal(t, pub1, pub1)
+	assert.NotEqual(t, pub1, pub2)
+}
+
 func TestPublicKeyEncoding(t *testing.T) {
 	pub, _ := GenerateTestKeyPair()
 	w1 := util.NewFixedWriter(20)

crypto/bls/signature_test.go

@@ -28,6 +28,17 @@ func TestSignatureCBORMarshaling(t *testing.T) {
 	assert.Error(t, sig2.UnmarshalCBOR(data))
 }
 
+func TestSignatureEqualsTo(t *testing.T) {
+	signer := GenerateTestSigner()
+	sig1 := signer.SignData([]byte("foo"))
+	sig2 := signer.SignData([]byte("bar"))
+
+	assert.True(t, sig1.EqualsTo(sig1))
+	assert.False(t, sig1.EqualsTo(sig2))
+	assert.Equal(t, sig1, sig1)
+	assert.NotEqual(t, sig1, sig2)
+}
+
 func TestSignatureEncoding(t *testing.T) {
 	_, prv := GenerateTestKeyPair()
 	sig := prv.Sign(util.Uint64ToSlice(util.RandUint64(0)))

util/io_test.go

@@ -51,7 +51,7 @@ func TestTempFile(t *testing.T) {
 	tmpFile := TempFilePath()
 
 	assert.True(t, IsAbsPath(tmpFile))
-	t.Run("Should panic because it doesn't exists", func(t *testing.T) {
+	t.Run("Should panic because it doesn't exist", func(t *testing.T) {
 		defer func() {
 			if r := recover(); r == nil {
 				t.Errorf("The code did not panic")

wallet/client_test.go

@@ -12,9 +12,7 @@ type blockchainServer struct{}
 type transactionServer struct{}
 
 var tBlockchainInfoResponse *pactus.GetBlockchainInfoResponse
-var tAccountRequest *pactus.GetAccountRequest
 var tAccountResponse *pactus.GetAccountResponse
-var tValidatorRequest *pactus.GetValidatorRequest
 var tValidatorResponse *pactus.GetValidatorResponse
 
 func (s *blockchainServer) GetBlockchainInfo(_ context.Context,
@@ -44,7 +42,7 @@ func (s *blockchainServer) GetBlock(_ context.Context,
 
 func (s *blockchainServer) GetAccount(_ context.Context,
 	req *pactus.GetAccountRequest) (*pactus.GetAccountResponse, error) {
-	if req.Address == tAccountRequest.Address {
+	if tAccountResponse != nil {
 		return tAccountResponse, nil
 	}
 	return nil, fmt.Errorf("unknown request")
@@ -57,7 +55,7 @@ func (s *blockchainServer) GetValidatorByNumber(_ context.Context,
 
 func (s *blockchainServer) GetValidator(_ context.Context,
 	req *pactus.GetValidatorRequest) (*pactus.GetValidatorResponse, error) {
-	if req.Address == tValidatorRequest.Address {
+	if tValidatorResponse != nil {
 		return tValidatorResponse, nil
 	}
 	return nil, fmt.Errorf("unknown request")