Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added GetTotalAccounts & GetTotalValidators into GetBlockchainInfo. #439

Merged
merged 3 commits into from Mar 30, 2023

Conversation

yenkhoon
Copy link
Contributor

Description

Added GetTotalAccounts and GetTotalValidators into GetBlockchainInfo

Related issue(s)

#438

Checklist

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • CHANGELOG is updated.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@955357c). Click here to learn what that means.
The diff coverage is 80.76%.

❗ Current head 97cbeb2 differs from pull request most recent head 3ab3cb1. Consider uploading reports for the commit 3ab3cb1 to get more accurate results

@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage        ?   82.15%           
=======================================
  Files           ?      148           
  Lines           ?     6947           
  Branches        ?        0           
=======================================
  Hits            ?     5707           
  Misses          ?      950           
  Partials        ?      290           

Copy link
Collaborator

@b00f b00f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yenkhoon Everything looks good. Just some minor linting issues.

The redefines-builtin-id rule in Revive is reporting an error in our code related to the use of the reserved words like copy. To address this issue, we can rename copy to clone.

@yenkhoon
Copy link
Contributor Author

yenkhoon commented Mar 29, 2023

@yenkhoon Everything looks good. Just some minor linting issues.

The redefines-builtin-id rule in Revive is reporting an error in our code related to the use of the reserved words like copy. To address this issue, we can rename copy to clone.

Ok! Let me fix tht.

@b00f b00f merged commit a8c6be9 into pactus-project:main Mar 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants