Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): fixing relay connection issue #475

Merged
merged 5 commits into from May 22, 2023

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented May 19, 2023

Description

This PR

  • Resolves the relay connection issue
  • Refactors network tests for improved readability
  • Updates the libp2p library

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #475 (6d86574) into main (8e38b48) will increase coverage by 0.26%.
The diff coverage is 73.23%.

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
+ Coverage   82.48%   82.74%   +0.26%     
==========================================
  Files         149      150       +1     
  Lines        7007     7049      +42     
==========================================
+ Hits         5780     5833      +53     
+ Misses        937      922      -15     
- Partials      290      294       +4     

network/config.go Outdated Show resolved Hide resolved
network/network.go Show resolved Hide resolved
network/network.go Outdated Show resolved Hide resolved
network/network.go Outdated Show resolved Hide resolved
network/network.go Outdated Show resolved Hide resolved
network/stream.go Show resolved Hide resolved
Copy link
Contributor

@yenkhoon yenkhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good.

@b00f b00f enabled auto-merge (squash) May 22, 2023 12:52
@b00f b00f merged commit ca14e98 into pactus-project:main May 22, 2023
12 checks passed
@b00f b00f deleted the relay-test branch May 23, 2023 11:02
b00f added a commit to b00f/pactus that referenced this pull request May 25, 2023
* fix(network): fixing relay connection issue

* test: fixing config tests

* test: fixing a possible race condition in network tests

* fix: fixing review comments

* style: updating some logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants