fix(network): closing the mDNS connection upon stopping the network #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #508 +/- ##
==========================================
+ Coverage 82.95% 83.05% +0.10%
==========================================
Files 154 154
Lines 7305 7307 +2
==========================================
+ Hits 6060 6069 +9
+ Misses 961 954 -7
Partials 284 284 |
b00f
force-pushed
the
mdns-stop
branch
3 times, most recently
from
20beefe
to
0ccc651
Compare
themantre
approved these changes
Jun 15, 2023
b00f
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The mDNS service was not closed after stopping the network. This PR addresses this issue by implementing the necessary closure. Additionally, it aims to resolve a random test failure that occurs in GitHub Actions, particularly on Windows. An example of such failure can be found at: https://github.com/pactus-project/pactus/actions/runs/5255419093/jobs/9495309402