Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gui): display network ID #780

Merged
merged 6 commits into from Oct 26, 2023

Conversation

thesloppyguy
Copy link
Contributor

Description

Added a function to return Network object from Node which will help in Displaying the Node ID in the UI.

Related issue(s)

/claim #761

@thesloppyguy thesloppyguy changed the title Feat/network id UI Feat: Network id UI Oct 24, 2023
@thesloppyguy thesloppyguy changed the title Feat: Network id UI feat: Network id UI Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #780 (8a30357) into main (1804fd3) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 8a30357 differs from pull request most recent head 374c48d. Consider uploading reports for the commit 374c48d to get more accurate results

@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
+ Coverage   82.82%   82.83%   +0.01%     
==========================================
  Files         172      172              
  Lines        8126     8133       +7     
==========================================
+ Hits         6730     6737       +7     
  Misses       1077     1077              
  Partials      319      319              

@b00f b00f changed the title feat: Network id UI feat(gui): display network ID Oct 25, 2023
@b00f
Copy link
Collaborator

b00f commented Oct 26, 2023

@thesloppyguy Thanks

@b00f b00f merged commit 3b95660 into pactus-project:main Oct 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obtain the network_key id in GUI
2 participants