fix: fixing logger issue on rotating log file #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
=======================================
Coverage 83.16% 83.16%
=======================================
Files 170 170
Lines 8552 8554 +2
=======================================
+ Hits 7112 7114 +2
Misses 1100 1100
Partials 340 340 |
themantre
approved these changes
Dec 12, 2023
themantre
approved these changes
Dec 12, 2023
themantre
pushed a commit
that referenced
this pull request
Dec 12, 2023
themantre
pushed a commit
that referenced
this pull request
Dec 12, 2023
themantre
pushed a commit
that referenced
this pull request
Dec 12, 2023
themantre
pushed a commit
that referenced
this pull request
Dec 12, 2023
themantre
pushed a commit
that referenced
this pull request
Dec 12, 2023
themantre
pushed a commit
that referenced
this pull request
Dec 12, 2023
themantre
pushed a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates one writer when initializing the global logger to prevent the file from being locked by sub-loggers.
Related issue(s)