Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gRPC): adding AvailabilityScore to gRPC #910

Merged
merged 22 commits into from Jan 7, 2024

Conversation

izikdepth
Copy link
Contributor

@izikdepth izikdepth commented Jan 6, 2024

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Merging #910 (8a8dc5b) into main (af79546) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   83.46%   83.43%   -0.03%     
==========================================
  Files         173      173              
  Lines        8815     8816       +1     
==========================================
- Hits         7357     7356       -1     
- Misses       1106     1107       +1     
- Partials      352      353       +1     

www/grpc/blockchain.go Outdated Show resolved Hide resolved
www/grpc/blockchain.go Outdated Show resolved Hide resolved
@kehiy
Copy link
Contributor

kehiy commented Jan 6, 2024

@izikdepth Thanks!

www/grpc/blockchain.go Outdated Show resolved Hide resolved
@kehiy
Copy link
Contributor

kehiy commented Jan 6, 2024

@b00f I think there is no need for account and vote to proto function to be methods of blockchain server!? they don't use any part of it.

@b00f
Copy link
Collaborator

b00f commented Jan 6, 2024

@kehiy let's keep all the same. You are write, but that way we have harmony in our functions.

@kehiy kehiy requested a review from b00f January 6, 2024 16:12
www/grpc/blockchain.go Outdated Show resolved Hide resolved
www/grpc/blockchain.go Outdated Show resolved Hide resolved
www/grpc/blockchain.go Outdated Show resolved Hide resolved
www/grpc/blockchain.go Outdated Show resolved Hide resolved
@kehiy
Copy link
Contributor

kehiy commented Jan 6, 2024

@b00f we can merge it.

www/grpc/blockchain.go Outdated Show resolved Hide resolved
@b00f
Copy link
Collaborator

b00f commented Jan 6, 2024

@kehiy Please merge it is tests are passed. Then we can integrate it with our Bot

@kehiy
Copy link
Contributor

kehiy commented Jan 6, 2024

@izikdepth run make proto then push your changes.
proto files dose not re generated.

@b00f b00f merged commit 1b5f3c1 into pactus-project:main Jan 7, 2024
12 checks passed
@b00f
Copy link
Collaborator

b00f commented Jan 7, 2024

@izikdepth Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Availability Score to gRPC
3 participants