Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Traditional (Taiwan) Translation #547

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Chinese Traditional (Taiwan) Translation #547

merged 2 commits into from
Aug 10, 2022

Conversation

rhuba8324
Copy link
Contributor

Simply as indicated by the title, translation for taiwanese's chinese.

Missing 2 following lines because I currerently don't know where they appears.
"by {0}"
"{0} on {1}"

Linked to #248

Simply as indicated by the title, translation for taiwanese's chinese.

Missing 2 following lines because I currerently don't know where they appears.
"by {0}"
"{0} on {1}"
@CLAassistant
Copy link

CLAassistant commented Aug 9, 2022

CLA assistant check
All committers have signed the CLA.

@BrunoBernardino
Copy link
Contributor

Thank you so much @rhuba8324, this is great! The first one appears when showing who last updated an item:

<div class="animated double-margined spacing faded tiny centering horizontal layout">
<pl-icon icon="edit"></pl-icon>
<div>
${until(formatDateFromNow(updated!))}
${updatedByMember && " " + $l("by {0}", updatedByMember.email)}
</div>
</div>

The second one appears on the device information's description ("Chrome on Windows", for example):

description:
browser.name && browser.name !== "Electron"
? $l("{0} on {1}", browser.name, platform)
: $l("{0} Device", platform),

Let me know if you want to address those, otherwise I can just merge this. Thanks again!

completed translation for "by {0}" and "{0} on {1}"
@rhuba8324
Copy link
Contributor Author

rhuba8324 commented Aug 10, 2022

The translation is now fully completed thanks to your help!
I think it's now ready to be merged. I will still look for improvement for future versions, but it's as good as it gets right now.
:D

@BrunoBernardino BrunoBernardino merged commit 781cfd3 into padloc:main Aug 10, 2022
@BrunoBernardino
Copy link
Contributor

谢谢 @rhuba8324 !

@MaKleSoft
Copy link
Collaborator

Thanks you so much for your contribution, @rhuba8324! Are you on Twitter by any chance? Would love to give you a shout-out (if that's ok with you).

@rhuba8324
Copy link
Contributor Author

I appreciate that, but I don't have a Twitter account since we rarely use that in where I live.
But I'm okay if you want to do a new locale support announcement simply with my github user name. :D

@rhuba8324 rhuba8324 deleted the patch-1 branch August 24, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants