Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing problems #1982

Closed
akemrir opened this issue Oct 26, 2015 · 5 comments
Closed

Routing problems #1982

akemrir opened this issue Oct 26, 2015 · 5 comments
Assignees
Labels

Comments

@akemrir
Copy link

akemrir commented Oct 26, 2015

I have upgraded my new project to 0.13 and I have routing problems.

It is possible now to pass multiple optional parameters with proper nesting?
In padrino 0.12.5 I could write:

q = { per_page: 2, page: 4 }
url_for(:notes, :index, query: q, beta: 50)

which build route to:

/notes?query[per_page]=2&query[page]=4&beta=50

In 0.13 this is not possible anymore, it doesn't build properly:

/notes?query={:per_page=%3E%222%22,%20:page=%3E%224%22}&beta=50 

In new version query parameter is string in controller and it seems to not transform passed hash.
This is a bug? Is there workaround?

@nesquena
Copy link
Member

/cc @namusyaka

@namusyaka namusyaka self-assigned this Oct 26, 2015
@namusyaka
Copy link
Contributor

Thanks for the report.
I'm going to fix the problem in a few days.

@namusyaka
Copy link
Contributor

This is a mustermann's problem. I'd like to fix. Maybe the patch can be provided in this week.

ujifgc added a commit that referenced this issue Oct 30, 2015
Support nested query for expanding path, fixes #1982
@namusyaka
Copy link
Contributor

@akemrir Fixed. Please let us know if you still have a problem. Thank you!

@akemrir
Copy link
Author

akemrir commented Oct 30, 2015

@namusyaka Works all right in 0.13.1.beta1. Thanks for fast responce and fix.
Good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants