Replace with new router (discussion) #1800

ujifgc · 2014-10-29T06:53:33Z

Oh, such a nice number, #1800!

…up-exceptions Bubble up router exceptions

- the `params` variable is converted into a HashWithIndifferentAccess object - fixes #1405 Conflicts: padrino-core/lib/padrino-core/application/routing.rb

Conflicts: padrino-core/lib/padrino-core/mounter.rb

Change Mustermann::Rails to Mustermann::Sinatra.

Conflicts: padrino-core/lib/padrino-core/application/routing.rb padrino-core/lib/padrino-core/support_lite.rb padrino-core/test/test_routing.rb

Conflicts: Gemfile padrino-core/lib/padrino-core/application/routing.rb padrino-core/padrino-core.gemspec padrino-core/test/test_routing.rb

Conflicts: padrino-core/lib/padrino-core/application/routing.rb

Conflicts: padrino-core/lib/padrino-core/application/routing.rb padrino-core/lib/padrino-core/ext/http_router.rb padrino-core/lib/padrino-core/loader.rb padrino-core/test/test_application.rb

ujifgc · 2014-10-29T06:54:42Z

padrino-core/padrino-core.gemspec

@@ -29,7 +29,11 @@ Gem::Specification.new do |s|
  else
    s.add_dependency("sinatra", "~> 1.4.2")
  end
-  s.add_dependency("http_router", "~> 0.11.0")
+  if RUBY_VERSION < '2.0.0'


This condition won't work in gemspec. It's evaluated on the developer's box, not on user's one.

What about giving a warning on install about this or just appending it to the Gemfile?

Yeah, thanks. If I understand things correctly, we should use mustermann19 because the official mustermann doesn't support for rubinius and jruby yet.

… for string arguments

ujifgc · 2014-10-29T11:39:51Z

For this test.
Mustermann19's default encoding is ASCII on the ruby1.9 environment.
Any ideas?

It's not mustermann19, it's Rack's encoding. And ruby2 seems to silently re-encode the request path_info on demand. Looks fixed after 54d350c

namusyaka · 2014-10-29T11:42:39Z

Great, I've misunderstood. Thanks!

refactor and change style of path_router

…framework into replace-with-new-router

But this function doesn't respect the Sinatra behavior If you want to use this, you must add RegexpLookAlike#to_s, RegexpLookAlike#names and MatchData#names

ujifgc · 2014-11-06T06:52:47Z

Should we just merge it to master and bump the version to 0.13.0.rc1? This PR is beginning to look like a mess.

namusyaka · 2014-11-06T07:03:47Z

Yes. We can merge this branch if there is no problem.

dariocravero · 2014-11-06T09:51:06Z

👍
On 6 Nov 2014 07:03, "namusyaka" notifications@github.com wrote:

Yes. We can merge this branch if there is no problem.

—
Reply to this email directly or view it on GitHub
#1800 (comment)
.

Replace with new router

namusyaka and others added 30 commits September 16, 2013 07:08

Add mustermann to Gemfile and padrino-core.gemspec.

c3514de

Replace http_router with the new router.

01f5726

Remove a skip, and change restful test routing for integrity.

9b77127

Bubble up router exceptions.

9c717e6

Merge pull request #1433 from padrino/replace-with-new-router-bubble-…

51c98c4

…up-exceptions Bubble up router exceptions

Use symbol instead of block if available.

e503167

Change request.accepts to an empty array if request.accepts is */*.

aca1f0e

Change accessor name, fix cache_expires for Moneta.

c938127

Catch NotFound and MethodNotAllowed.

f30fe10

Small refactoring.

b72659f

issue #1405 - params hash keys

ffe946d

- the `params` variable is converted into a HashWithIndifferentAccess object - fixes #1405 Conflicts: padrino-core/lib/padrino-core/application/routing.rb

Fix params hash keys.

9846e2c

Disambiguate the behavior of url.

fa9cecc

Conflicts: padrino-core/lib/padrino-core/mounter.rb

Change Mustermann::Rails to Mustermann::Sinatra.

c11e7a6

Merge pull request #1497 from namusyaka/change-rails-to-sinatra

3fe3e5d

Change Mustermann::Rails to Mustermann::Sinatra.

Merge branch 'master' into replace-with-new-router

65a5c21

Conflicts: padrino-core/lib/padrino-core/application/routing.rb padrino-core/lib/padrino-core/support_lite.rb padrino-core/test/test_routing.rb

Merge branch 'master' into replace-with-new-router

7ac0f8b

Conflicts: Gemfile padrino-core/lib/padrino-core/application/routing.rb padrino-core/padrino-core.gemspec padrino-core/test/test_routing.rb

Merge branch 'master' into replace-with-new-router

6d0450f

Conflicts: padrino-core/lib/padrino-core/application/routing.rb

Merge branch 'master' into replace-with-new-router

90c8c27

Merge branch 'master' into replace-with-new-router

8b5302b

Conflicts: padrino-core/lib/padrino-core/application/routing.rb

Merge branch 'master' into replace-with-new-router

28853bb

fix tests for new router

e1232dd

Merge branch 'master' into replace-with-new-router

5a96690

Merge branch 'master' into replace-with-new-router

1db2bed

Conflicts: padrino-core/lib/padrino-core/application/routing.rb

Split path_router.rb

2157871

Refactor

3eeda3d

Switch old syntax to Ruby2.0 syntax

c4a672b

Merge branch 'master' into replace-with-new-router

9df25ac

Performance improvement of new router

408bee2

Implement :precompile_routes option

066dc1f

namusyaka and others added 3 commits September 25, 2014 01:40

Don't treat internal keys as symbol

829d2f8

Small refactoring, and docs are available

15593fd

Merge branch 'master' into replace-with-new-router

ab85ea2

Conflicts: padrino-core/lib/padrino-core/application/routing.rb padrino-core/lib/padrino-core/ext/http_router.rb padrino-core/lib/padrino-core/loader.rb padrino-core/test/test_application.rb

ujifgc reviewed Oct 29, 2014
View reviewed changes

namusyaka added 2 commits October 29, 2014 18:39

Fix some tests

de11a51

Remove old private method

69d000c

namusyaka added the router label Oct 29, 2014

namusyaka self-assigned this Oct 29, 2014

namusyaka and others added 3 commits October 29, 2014 19:51

Use mustermann19 in all cases

282d670

Don't pass args in Regexp.last_match because rubinius doesn't support…

edd7877

… for string arguments

remove force_encoding abuse

54d350c

ujifgc added this to the 0.13.0 milestone Oct 30, 2014

namusyaka and others added 7 commits November 4, 2014 16:32

Merge branch 'master' into replace-with-new-router

b8d09b3

refactor and change style of path_router

74044a1

Merge pull request #1811 from padrino/refactor-new-router

7037e35

refactor and change style of path_router

Merge branch 'replace-with-new-router' of github.com:padrino/padrino-…

1d460d4

…framework into replace-with-new-router

Merge branch 'master' into replace-with-new-router

e0ebdbb

Support named capture on regexp, and small refactoring

3551508

Support regular expression look-alike routes

32a08e4

But this function doesn't respect the Sinatra behavior If you want to use this, you must add RegexpLookAlike#to_s, RegexpLookAlike#names and MatchData#names

ujifgc added a commit that referenced this pull request Nov 6, 2014

Merge pull request #1800 from padrino/replace-with-new-router

2f079c3

Replace with new router

ujifgc merged commit 2f079c3 into master Nov 6, 2014

ujifgc deleted the replace-with-new-router branch November 6, 2014 10:30

namusyaka mentioned this pull request Nov 7, 2014

Padrino's router design - i.e., retiring http_router #1339

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace with new router (discussion) #1800

Replace with new router (discussion) #1800

ujifgc commented Oct 29, 2014

ujifgc Oct 29, 2014

dariocravero Oct 29, 2014

namusyaka Oct 29, 2014

ujifgc commented Oct 29, 2014

namusyaka commented Oct 29, 2014

ujifgc commented Nov 6, 2014

namusyaka commented Nov 6, 2014

dariocravero commented Nov 6, 2014

Replace with new router (discussion) #1800

Replace with new router (discussion) #1800

Conversation

ujifgc commented Oct 29, 2014

ujifgc Oct 29, 2014

Choose a reason for hiding this comment

dariocravero Oct 29, 2014

Choose a reason for hiding this comment

namusyaka Oct 29, 2014

Choose a reason for hiding this comment

ujifgc commented Oct 29, 2014

namusyaka commented Oct 29, 2014

ujifgc commented Nov 6, 2014

namusyaka commented Nov 6, 2014

dariocravero commented Nov 6, 2014