Add custom args to SGMailV3 #7
Conversation
sendgrid_sender.go
Outdated
| @@ -23,7 +23,7 @@ type SendgridSender struct { | |||
|
|
|||
| //Send sends an email to Sendgrid for delivery, it assumes | |||
| //bodies[0] is HTML body and bodies[1] is text. | |||
| func (ps SendgridSender) Send(m mail.Message) error { | |||
| func (ps SendgridSender) Send(m mail.Message, customArgs ...map[string]string) error { | |||
There was a problem hiding this comment.
@tatang26 this will not work since it implies our Sender is no longer a [buffalo] mail.Sender. My recommendation would be to put these into Message.Data, we could then use a particular key to know that that's newrelic custom-args.
There was a problem hiding this comment.
@paganotoni You are right, I updated the buildMail function to add custom args from Message.Data
sendgrid_sender.go
Outdated
| @@ -73,6 +73,10 @@ func buildMail(m mail.Message) (*smail.SGMailV3, error) { | |||
| p.AddTos(smail.NewEmail(to.Name, to.Address)) | |||
| } | |||
|
|
|||
| for k, v := range m.Data { | |||
| p.SetCustomArg(k, v.(string)) | |||
There was a problem hiding this comment.
Very close! we now need to use just one of the keys in that m.Data for this purpose. Also, we need to add documentation in our README that explains how to add custom args.
sendgrid_sender.go
Outdated
| @@ -73,6 +73,10 @@ func buildMail(m mail.Message) (*smail.SGMailV3, error) { | |||
| p.AddTos(smail.NewEmail(to.Name, to.Address)) | |||
| } | |||
|
|
|||
| for k, v := range m.Data { | |||
| p.SetCustomArg(k, fmt.Sprintf("%v", v)) | |||
There was a problem hiding this comment.
Here it should be something like:
if customArgs, ok := m.Data[CustomArgsKey].(CustomArgs); ok {
[iterate through CustomArgs]
}CustomArgsKey should be a constant in this package.
CustomArgs should be a type map[string]string
No description provided.