Support custom options at message-builder #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianopf
requested review from
vlopes,
Thor99,
alinemarjorie,
hugocarreira and
jeanaugustoos
alinemarjorie
approved these changes
Jan 23, 2020
|
#euvi #eutava |
Thor99
approved these changes
Jan 23, 2020
|
Por que o coverage caiu tanto? @lucianopf |
Na verdade ele caiu meio porcento, mas não consigo entender pq, dps vou caçar 100% de coverage dnv Eu até testei o fluxo que alterei por completo 😢 |
|
É que na README.md (da master) ta 89%, ai assustei quando vi o resultado aqui do PR.. mas de boa moço |
hugocarreira
approved these changes
Jan 23, 2020
matheusvellone
approved these changes
Jan 24, 2020
|
Quando for pro ar, só me avisar q eu público no npm. Inclusive, já faz o bump na versão. Acho q pra esse caso, faz sentido ser um |
|
Consigo tbm publicar, vou fazer então um commit com o bump e quando for publicar de dou um toque, VLW!! 😍 |
flyingluscas
approved these changes
Jan 24, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to update how we merge the logger options with the message options, enabling it to be overwritten by the logger message options.
The main example is enabling the overwrite when logging a specific message setting a custom service name.