Fix checkout/order-pay tabs incompatibility #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfwill-dev
requested review from
GabrielDeveloper,
michelpl and
netorodrigues
GabrielDeveloper
approved these changes
Feb 25, 2021
netorodrigues
approved these changes
Feb 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<li>tag as the first tab, so the click does nothing. NOTES: Alternatively we could style or tabs using an own style, but it would take a lot more time and we probably would have theme compatibility issues, being necessary adding tab color settings to our plugin. Other alternative could be find another wordpress/woocommerce frontend common tab style to use, but unfortunately we didn't get to find one.Relates to: https://github.com/mundipagg/woocommerce/pull/19
📦 Attachments (if appropriate)
Woocommerce file which has the "click at the first tab" behaviour:
https://github.com/woocommerce/woocommerce/blob/master/assets/js/frontend/single-product.js#L25
Plugin which adds the single-product.js file to woocommerce order-pay page:
https://essential-addons.com/elementor/