Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Implemented column hide/show functionality and name change #339

Closed
wants to merge 4 commits into from

Conversation

ThomasLuu00
Copy link

@ThomasLuu00 ThomasLuu00 commented Oct 20, 2019

Description

This PR adds the enhancement specified in issue#318. The columns hidden status and names may be changed in the settings when a user is logged in. These settings will only appear when a user is logged in. The styling for the table is misaligned when columns are hidden. Please let me know if you would like me to fix that as well in my PR.

Fixes #318

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated changelog.md with changes made

@davidmckenzie
Copy link
Member

Oooh nice, will have to pull down and have a play. Dealing with the colspan attributes will be tough with this - it may need some fancy logic to determine those

@DanrwAU DanrwAU changed the base branch from master to v0.3.6 November 3, 2019 07:35
@DanrwAU
Copy link
Member

DanrwAU commented Nov 3, 2019

I've rebased this one to the 0.3.6 branch as we don't merge directly to master.
I'll try and test this one tonight..

@DanrwAU DanrwAU changed the base branch from v0.3.6 to v0.3.7 March 18, 2020 23:40
@DanrwAU DanrwAU changed the base branch from v0.3.7 to v0.3.8 April 21, 2020 10:24
@DanrwAU DanrwAU changed the base branch from v0.3.8 to v0.3.9 May 4, 2020 06:18
@DanrwAU DanrwAU added this to the 0.3.9 milestone May 4, 2020
@DanrwAU DanrwAU changed the base branch from v0.3.9 to v0.3.10 May 13, 2020 09:43
@DanrwAU DanrwAU closed this May 17, 2020
@DanrwAU DanrwAU reopened this May 17, 2020
@DanrwAU DanrwAU changed the base branch from v0.3.10 to develop June 24, 2020 11:01
@DanrwAU
Copy link
Member

DanrwAU commented Jan 22, 2021

This one is likely broken since the settings changes per user in 0.3.9.

Will likely need to be redone for merge. @ThomasLuu00 still interested in this one?

@DanrwAU DanrwAU changed the title Implemented column hide/show functionality and name change WIP Implemented column hide/show functionality and name change Jan 22, 2021
@DanrwAU
Copy link
Member

DanrwAU commented Dec 21, 2022

Abandonned - no commits in 3 years

@DanrwAU DanrwAU closed this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants