Closes #340: New modal for messages

[ThomasLuu00]

Description

I added a modal for when a message is clicked that shows all the details for the message. It still requires some styling but the functionality is there.

Fixes #340

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have updated changelog.md with changes made

[davidmckenzie]

Nice one, looks like this includes the changes from #339 as well though. Feel free to submit with only the modal changes, as I suspect we'll need to rework #339 a bit before it merges in due to the issues with colspan on the headers, and formatting issues

[DanrwAU]

Changed the base branch to v0.3.6 - we don't merge directly to master.

[marshyonline]

server/public/templates/myModalContent.html is too generic of a name.

[marshyonline]

Other than the outlined issues - I really like the idea and am keen to see it implemented

[ThomasLuu00]

I have removed the old commits from #339 and changed the modal file name as requested.

[ThomasLuu00]

Okay, I think I messed up the rebase so it's not working, will try to fix it again.

[ThomasLuu00]

Fixed the problem, works now

[marshyonline]

I feel like we can clean this up a bit

It is not respecting "Hide Source"
It seems to be respecting "Hide Capcode" but is showing an empty field -
I feel Source and Capcode should be removed from the box if these options are enabled
@DanrwAU & @davidmckenzie Thoughts?

Formatting is easy, I can add this once the above is good

[marshyonline]

Oh and please add your change to the CHANGELOG :)

[DanrwAU]

It is not respecting "Hide Source"
It seems to be respecting "Hide Capcode" but is showing an empty field -
I feel Source and Capcode should be removed from the box if these options are enabled
@DanrwAU & @davidmckenzie Thoughts?

Agreed needs to hide these fields if they are set to be hidden. Also needs some prettiness, that's not my wheelhouse tho

[ThomasLuu00]

If someone has an idea of how it should look, I will add the style changes. But yes, I will add some changes to respect the hidden columns settings.

[ThomasLuu00]

I have updated the changelog and implemented the hidesource and hidecapcode changes.

[s3m1s0n1c]

Is there an option to turn it off as I probably wouldn't want this on my site..

Sorry to be annoying..

Thanks
Sonic

[davidmckenzie]

@s3m1s0n1c it should only display on mobile view when columns are truncated, where it would be useful. May consider moving it to an unobtrusive button pinned to the right instead of from clicking the row

I'll take a look at prettifying this after the oracle saga is over :)

[marshyonline]

If this is for mobile only - I was seeing the Modal on a desktop

[eopo]

How about accordion view. We could even enable them on desktop to view maps or other stored plugin data 🤔

[marshyonline]

+1 for @eopo's idea

[davidmckenzie]

oooh accordian is nice, good idea, kinda like what I started on with #167 / #171 but never got around to finishing

[ThomasLuu00]

I added the change to make the modal so it only appears for mobile but not small browsers. But based on the discussion here, seems like an accordian view is more popular. I can work on that view as well, should I open up a new issue?

[DanrwAU]

Is this one cancelled in favour of #348 ?

[DanrwAU]

Abandonned - no commits in 3 years