Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Firma con IO): [SFEQS-1049] Add documents screen with navigation bar #4180

Merged
merged 51 commits into from
Nov 22, 2022

Conversation

hevelius
Copy link
Contributor

@hevelius hevelius commented Nov 16, 2022

Short description

In this PR has been added the FciDocumentsScreen and a Documents navigation bar to easily navigate between documents and pages.

Screen.Recording.2022-11-16.at.18.42.52.mp4

List of changes proposed in this pull request

  • Added FciDocumentsScreen
  • Added DocumentsNavigationBar component
  • Added new locales
  • Updated FciStackNavigator
  • Added some tests

How to test

hevelius and others added 30 commits November 9, 2022 10:40
Co-authored-by: Francesco Persico <francescopersico@gmail.com>
Co-authored-by: Francesco Persico <francescopersico@gmail.com>
@hevelius hevelius requested review from a team and thisisjp as code owners November 16, 2022 11:54
@pagopa-github-bot pagopa-github-bot changed the title feat(Firma con IO): [SFEQS-1049] add documents screen with navigation bar feat(Firma con IO): [SFEQS-1049] Add documents screen with navigation bar Nov 16, 2022
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 16, 2022

Affected stories

  • 🌟 SFEQS-1049: Come USER voglio poter visualizzare i documenti da firmare così da prenderne visione prima di apporre la firma
    subtask of

Generated by 🚫 dangerJS against 52e44ec

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #4180 (52e44ec) into master (bd78209) will increase coverage by 0.04%.
The diff coverage is 73.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4180      +/-   ##
==========================================
+ Coverage   47.81%   47.85%   +0.04%     
==========================================
  Files        1343     1344       +1     
  Lines       25677    25720      +43     
  Branches     6700     6714      +14     
==========================================
+ Hits        12277    12308      +31     
- Misses      13349    13360      +11     
- Partials       51       52       +1     
Impacted Files Coverage Δ
ts/features/fci/navigation/FciStackNavigator.tsx 75.00% <ø> (ø)
.../features/fci/screens/valid/FciDocumentsScreen.tsx 68.42% <68.42%> (-31.58%) ⬇️
...features/fci/components/DocumentsNavigationBar.tsx 100.00% <100.00%> (ø)
...features/fci/store/reducers/fciSignatureRequest.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd78209...52e44ec. Read the comment docs.

@francescopersico francescopersico merged commit 6311242 into master Nov 22, 2022
@hevelius hevelius deleted the SFEQS-1049-documents-screen branch May 9, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants