Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-773] Add patch to cipher-base package #5354

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

hevelius
Copy link
Contributor

Short description

This PR adds a patch to cipher-base package to solve an "issue" during proximity verification flow. It could be related on how io-app do the bundle of sub-dependencies (like import/export issue). The patch is also related to these issues on other repositories:

List of changes proposed in this pull request

  • Add patch file using patch-package

How to test

Static checks should be enough.

@pagopa-github-bot pagopa-github-bot changed the title [SIW-773] Add patch to cipher-base package chore(IT Wallet): [SIW-773] Add patch to cipher-base package Dec 19, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 19, 2023

Affected stories

  • ⚙️ SIW-773: [APP] Patch libreria cipher-base per supporto readable-stream

Generated by 🚫 dangerJS against b1af5b2

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (843b4b7) 46.36% compared to head (b1af5b2) 46.36%.
Report is 2 commits behind head on bundle/it-wallet.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           bundle/it-wallet    #5354   +/-   ##
=================================================
  Coverage             46.36%   46.36%           
=================================================
  Files                  1638     1638           
  Lines                 34010    34010           
  Branches               8245     8245           
=================================================
  Hits                  15769    15769           
  Misses                18190    18190           
  Partials                 51       51           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8f59e...b1af5b2. Read the comment docs.

@hevelius hevelius marked this pull request as ready for review December 19, 2023 18:21
@hevelius hevelius requested a review from a team as a code owner December 19, 2023 18:21
Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's document this in our backport diary.

@hevelius hevelius merged commit a9242c1 into bundle/it-wallet Dec 20, 2023
6 checks passed
@hevelius hevelius deleted the SIW-773-cipher-base-patch branch December 20, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants