Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-778] Add actions and reducer for proximity flow #5359

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

hevelius
Copy link
Contributor

@hevelius hevelius commented Dec 20, 2023

Short description

This PR adds actions and reducers for proximity flow.

NOTE: this is an experimental proposal to get proximity flow using redux-saga and could change in the future

List of changes proposed in this pull request

  • Add actions
  • Add reducers

How to test

Static checks should be enough

@pagopa-github-bot pagopa-github-bot changed the title [SIW-778] Add actions and reducer for proximity flow chore(IT Wallet): [SIW-778] Add actions and reducer for proximity flow Dec 20, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 20, 2023

Affected stories

  • ⚙️ SIW-778: [APP] Aggiungere reducer per flusso proximity
    subtask of
    • SIW-333: Presentazione in prossimità

Generated by 🚫 dangerJS against 7b98b5c

@hevelius hevelius marked this pull request as ready for review December 20, 2023 17:40
@hevelius hevelius requested a review from a team as a code owner December 20, 2023 17:40
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (843b4b7) 46.36% compared to head (7b98b5c) 46.36%.
Report is 3 commits behind head on bundle/it-wallet.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           bundle/it-wallet    #5359   +/-   ##
=================================================
  Coverage             46.36%   46.36%           
=================================================
  Files                  1638     1640    +2     
  Lines                 34010    34043   +33     
  Branches               8245     8254    +9     
=================================================
+ Hits                  15769    15785   +16     
- Misses                18190    18207   +17     
  Partials                 51       51           
Files Coverage Δ
...res/it-wallet/store/actions/itwProximityActions.ts 100.00% <100.00%> (ø)
ts/features/it-wallet/store/reducers/index.ts 66.66% <ø> (ø)
...es/it-wallet/store/reducers/itwProximityReducer.ts 37.03% <37.03%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9242c1...7b98b5c. Read the comment docs.

Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hevelius hevelius merged commit 0dc72d9 into bundle/it-wallet Dec 21, 2023
6 checks passed
@hevelius hevelius deleted the SIW-778-proximity-reducers branch December 21, 2023 09:31
hevelius added a commit that referenced this pull request Dec 21, 2023
### This PR depends on #5359 

## Short description
This PR adds proximity saga handlers.

NOTE: this is an experimental proposal about proximity flow using
redux-saga and could be change in future

## List of changes proposed in this pull request
- Add itwProximitySaga

## How to test
Static checks should be enough
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants