Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPLT-360] Upgrades react-native-webview to latest version #5538

Merged
merged 127 commits into from
May 8, 2024

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Feb 22, 2024

Caution

This PR depends on #5506

Short description

This PR aims to bump react-native-webview version to 13.8.1

List of changes proposed in this pull request

  • update library
  • updates secrity patch to work with latest version of the library code

How to test

Check the Webviews used through the app to check the consistency of the update

As a further test check the removal of the workaround introduced in #4460 doesn't introduce back the bug that should've been fixed in the base library

Copy link
Contributor

@hevelius hevelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on all relevant flows on iOS simulator, included the workaround introduced in #4460

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CrisTofani CrisTofani merged commit 4fd9378 into master May 8, 2024
13 checks passed
@CrisTofani CrisTofani deleted the IOPLT-360-react-native-webview-upgrade branch May 8, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants