chore: [IOPAE-1048,IOPAE-1049,IOPAE-1051] Adopt the new DS on ServiceDetailsScreen
#5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
ServiceDetailsScreenServiceDetailsScreen
Affected stories
|
Ladirico
requested changes
Apr 11, 2024
adelloste
added a commit
that referenced
this pull request
Apr 12, 2024
This pr depends on #5677 ## Short description This PR adds the skeleton for the loading state in `ServiceDetailsScreen`. <details open><summary>Details</summary> <p> | service details | | - | | <video src="https://github.com/pagopa/io-app/assets/29163287/befbec7c-57cb-42c7-9067-de424e8d49e7" width="300"/> | </p> </details> ## List of changes proposed in this pull request - updated ServiceDetailsScreen in order to display the skeleton ## How to test Using `io-dev-api-server`, navigate to the services tab and tap a service. Check that the screen is displayed correctly.
CrisTofani
pushed a commit
that referenced
this pull request
Apr 12, 2024
…eDetailsScreen` (#5677) ## Short description This PR updates the service details introducing the footer (special cta + standard ctas), the metadata and the tos&privacy sections. <details open><summary>Details</summary> <p> | without ctas | with ctas | | - | - | | <video src="https://github.com/pagopa/io-app/assets/29163287/b6b1e5ff-83d6-4be7-bb56-1bae553bf0b8" width="300"/> | <video src="https://github.com/pagopa/io-app/assets/29163287/32e5e218-24bb-4d76-a698-54fdfc675c9b" width="300"/> | | custom flow pn | custom flow cgn | | - | - | | <video src="https://github.com/pagopa/io-app/assets/29163287/da011192-47a9-42b2-913c-06d8d61222a4" width="300"/> | <video src="https://github.com/pagopa/io-app/assets/29163287/6f370405-896c-451c-b533-aa78f2682cd1" width="300"/> | </p> </details> ## List of changes proposed in this pull request - added `ServiceDetailsTosAndPrivacy` component to display Tos&Privacy section - added `ServiceDetailsMetadata` component to display metadata section - added `ServiceDetailsFooterActions` component to display footer: this component allows to display the **custom cta** for special services or the **standard ctas**. - updated the cta for the `pn` and `cgn` flows - updated langs ## How to test Using `io-dev-api-server`, navigate to the services tab and tap a service. Check that the screen is displayed correctly. --------- Co-authored-by: Alice Di Rico <83651704+Ladirico@users.noreply.github.com>
CrisTofani
pushed a commit
that referenced
this pull request
Apr 12, 2024
This pr depends on #5677 ## Short description This PR adds the skeleton for the loading state in `ServiceDetailsScreen`. <details open><summary>Details</summary> <p> | service details | | - | | <video src="https://github.com/pagopa/io-app/assets/29163287/befbec7c-57cb-42c7-9067-de424e8d49e7" width="300"/> | </p> </details> ## List of changes proposed in this pull request - updated ServiceDetailsScreen in order to display the skeleton ## How to test Using `io-dev-api-server`, navigate to the services tab and tap a service. Check that the screen is displayed correctly.
CrisTofani
pushed a commit
that referenced
this pull request
Apr 12, 2024
…eDetailsScreen` (#5677) ## Short description This PR updates the service details introducing the footer (special cta + standard ctas), the metadata and the tos&privacy sections. <details open><summary>Details</summary> <p> | without ctas | with ctas | | - | - | | <video src="https://github.com/pagopa/io-app/assets/29163287/b6b1e5ff-83d6-4be7-bb56-1bae553bf0b8" width="300"/> | <video src="https://github.com/pagopa/io-app/assets/29163287/32e5e218-24bb-4d76-a698-54fdfc675c9b" width="300"/> | | custom flow pn | custom flow cgn | | - | - | | <video src="https://github.com/pagopa/io-app/assets/29163287/da011192-47a9-42b2-913c-06d8d61222a4" width="300"/> | <video src="https://github.com/pagopa/io-app/assets/29163287/6f370405-896c-451c-b533-aa78f2682cd1" width="300"/> | </p> </details> ## List of changes proposed in this pull request - added `ServiceDetailsTosAndPrivacy` component to display Tos&Privacy section - added `ServiceDetailsMetadata` component to display metadata section - added `ServiceDetailsFooterActions` component to display footer: this component allows to display the **custom cta** for special services or the **standard ctas**. - updated the cta for the `pn` and `cgn` flows - updated langs ## How to test Using `io-dev-api-server`, navigate to the services tab and tap a service. Check that the screen is displayed correctly. --------- Co-authored-by: Alice Di Rico <83651704+Ladirico@users.noreply.github.com>
CrisTofani
pushed a commit
that referenced
this pull request
Apr 12, 2024
This pr depends on #5677 ## Short description This PR adds the skeleton for the loading state in `ServiceDetailsScreen`. <details open><summary>Details</summary> <p> | service details | | - | | <video src="https://github.com/pagopa/io-app/assets/29163287/befbec7c-57cb-42c7-9067-de424e8d49e7" width="300"/> | </p> </details> ## List of changes proposed in this pull request - updated ServiceDetailsScreen in order to display the skeleton ## How to test Using `io-dev-api-server`, navigate to the services tab and tap a service. Check that the screen is displayed correctly.
dhinterlechner
added a commit
to dhinterlechner/io-app
that referenced
this pull request
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR updates the service details introducing the footer (special cta + standard ctas), the metadata and the tos&privacy sections.
Details
without-ctas.mp4
with-ctas.mp4
cta-special-flow-send.mp4
cta-special-flow-cgn.mp4
List of changes proposed in this pull request
ServiceDetailsTosAndPrivacycomponent to display Tos&Privacy sectionServiceDetailsMetadatacomponent to display metadata sectionServiceDetailsFooterActionscomponent to display footer: this component allows to display the custom cta for special services or the standard ctas.pnandcgnflowsHow to test
Using
io-dev-api-server, navigate to the services tab and tap a service. Check that the screen is displayed correctly.