chore(IT Wallet): [SIW-1047] Add loading states to wallet screen #5707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastro993
changed the title
pagopa-github-bot
changed the title
mastro993
force-pushed
the
SIW-1047-add-loading-skeleton-to-wallet-screen
branch
from
b1f76fc
to
f2f8b9b
Compare
hevelius
reviewed
Apr 23, 2024
ts/features/newWallet/components/WalletCardsCategoryContainer.tsx
Outdated
Show resolved
Hide resolved
mastro993
added a commit
that referenced
this pull request
Apr 29, 2024
> [!WARNING] > This PR depends on #5707 ## Short description This PR adds a timeout for wallet card placeholder which are taking too long to load or will never be added again to the wallet. This allows to remove pending placeholders animation from the wallet section ## List of changes proposed in this pull request - Added `walletResetPlaceholders` action, reducer and sagas ## How to test You can test this PR easily with the `io-dev-api-server`, just add a new CGN card then restart the dev server. The app will wait for a CGN card to come but the server will never return any. ## Previews | Before | After | | --- | --- | | <video src="https://github.com/pagopa/io-app/assets/6160324/286361e8-3603-4b70-9c27-2ff6ff40ac0e" /> | <video src="https://github.com/pagopa/io-app/assets/6160324/b6885e40-f9dd-4ed8-ba9e-4883ad2df4a0" /> | --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the loading skeleton to the wallet screen. The loading logics handles the asynchronous mutation of wallet credentials and allows to show a loading skeleton for credentials that may be added to the wallet.
List of changes proposed in this pull request
withWalletCardBaseComponentHOC toWalletCardSkeletoncomponentWalletCardsCategoryContainerSkeletoncomponent, which displays a skeleton for a wallet category.WalletCardsContainerWalletHomeScreento improve code readibility and to handle loading logicsHow to test
With the
io-dev-api-server, enable the New wallet section FF from the profile screen. Navigate to the new wallet section and check that the loading state works as expected:Previews
loading_empty.mp4
loading_no_placeholders.mp4
loading_placeholders.mp4