Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPLT-515] Adds the saga to handle api requests on trial system #5777

Merged
merged 21 commits into from
Jun 27, 2024

Conversation

CrisTofani
Copy link
Contributor

Warning

This PR depends on #5776

Short description

This PR adds the saga to handle the requests on Trial System workflow

List of changes proposed in this pull request

  • Create watchTrialSystemSaga
  • Fork the new saga to the startupSaga

How to test

Check if the API call are properly dispatched

@CrisTofani CrisTofani requested a review from a team as a code owner May 16, 2024 10:01
@pagopa-github-bot pagopa-github-bot changed the title [IOPLT-515] Adds the saga to handle api requests on trial system chore: [IOPLT-515] Adds the saga to handle api requests on trial system May 16, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 16, 2024

Affected stories

  • ⚙️ IOPLT-515: Aggiungere la saga per avviare la richiesta di sperimentazione
    subtask of
    • 🌟 IOPLT-484: Come USER voglio poter disporre di una CTA per richiedere l'adesione ad una sperimentazione

Generated by 🚫 dangerJS against bb549b0

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 49.68%. Comparing base (4f204b4) to head (bb549b0).
Report is 218 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5777      +/-   ##
==========================================
+ Coverage   48.42%   49.68%   +1.25%     
==========================================
  Files        1488     1719     +231     
  Lines       31617    33841    +2224     
  Branches     7669     8171     +502     
==========================================
+ Hits        15311    16813    +1502     
- Misses      16238    16966     +728     
+ Partials       68       62       -6     
Files Coverage Δ
ts/sagas/startup.ts 30.05% <0.00%> (-0.41%) ⬇️
ts/features/trialSystem/api/client.ts 25.00% <25.00%> (ø)
...es/trialSystem/store/sagas/watchTrialSystemSaga.ts 0.00% <0.00%> (ø)

... and 822 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a99b1...bb549b0. Read the comment docs.

@CrisTofani CrisTofani changed the base branch from IOPLT-514-trial-system-redux-store to master May 21, 2024 13:07
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected 🚀

@CrisTofani CrisTofani merged commit 5538ed0 into master Jun 27, 2024
13 checks passed
@CrisTofani CrisTofani deleted the IOPLT-515-trial-system-handling-saga branch June 27, 2024 13:10
@CrisTofani CrisTofani restored the IOPLT-515-trial-system-handling-saga branch June 27, 2024 13:10
@CrisTofani CrisTofani deleted the IOPLT-515-trial-system-handling-saga branch June 27, 2024 13:12
CrisTofani added a commit that referenced this pull request Jun 27, 2024
…5794)

> [!warning]
> This PR depends on #5777 

## Short description
This PR aims to add a new screen with CTA to handle the loading status
of a specific trial under profile section

## List of changes proposed in this pull request
- Adds the TrialSystemPlayground under Playground section of
Profile/DeveloperSection

## How to test
Try to start the subscription by using this PR code on dev-server
pagopa/io-dev-api-server#378

---------

Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants