chore: [IOCOM-1525] PAID badge, new DS #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ts/features/messages/store/reducers/allPaginated.ts
pagopa-github-bot
changed the title
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5877 +/- ##
==========================================
+ Coverage 48.42% 49.59% +1.16%
==========================================
Files 1488 1714 +226
Lines 31617 33803 +2186
Branches 7669 8110 +441
==========================================
+ Hits 15311 16765 +1454
- Misses 16238 16984 +746
+ Partials 68 54 -14
... and 817 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
# Conflicts: # ts/features/messages/store/reducers/allPaginated.ts
|
🎉 All dependencies have been resolved ! |
# Conflicts: # ts/features/messages/components/Home/DS/DoubleAvatar.tsx # ts/features/messages/components/Home/DS/MessageListItem.tsx # ts/features/messages/components/Home/WrappedMessageListItem.tsx # ts/features/messages/components/Home/__tests__/__snapshots__/WrappedMessageListItem.test.tsx.snap
# Conflicts: # ts/features/messages/store/reducers/__tests__/allPaginated.test.ts # ts/features/messages/store/reducers/allPaginated.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR enables the PAID badge on messages in the new DS messages' home.
List of changes proposed in this pull request
MessageListItem: support forsuccessbadgeVariantWrappedMessageListItem: business logic forbadgeVariantandbadgeTextallPaginatedrefactoredisNoticePaidSelectorintoisPaymentMessagewithPaidNoticeSelectorHow to test
Using the io-dev-api-server, generate some messages with and without payment. Make sure to enable both DS and new Home. Select a message with a payment and pay it. The related message's cell should display the PAID badge.
Be aware that SEND messages with payments do not display the PAID badge.