-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-328] Add the new CircularProgress
component + Remove react-native-progress-circle
dependency
#5890
Conversation
CircularProgress
component + Remove react-native-progress-circle
dependencyCircularProgress
component + Remove react-native-progress-circle
dependency
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5890 +/- ##
==========================================
+ Coverage 48.42% 49.55% +1.13%
==========================================
Files 1488 1703 +215
Lines 31617 33741 +2124
Branches 7669 8214 +545
==========================================
+ Hits 15311 16721 +1410
- Misses 16238 16959 +721
+ Partials 68 61 -7
... and 793 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀. Tested on both Android and iOS
🤖 | 🍏 |
---|---|
default.mov |
default.mov |
Short description
This PR adds the new
CircularProgress
component, which replaces the old one built with the (abandoned)react-native-progress-circle
micro-library. The new component is built with thereanimated
library and doesn't generate errors with the new0.72
RN version, unlike the current implementation.List of changes proposed in this pull request
CircularProgress
componentCieReadingCardAnimation
intoCieCardReadingAnimation
for consistency with otherCieCard…
related filesreact-native-progress-circle
dependencyPreview
cie-card-reading-animation.mov
Related PR
How to test
Try to access the app with CIE auth flow