Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-328] Add the new CircularProgress component + Remove react-native-progress-circle dependency #5890

Merged
merged 13 commits into from
Jun 25, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jun 21, 2024

Short description

This PR adds the new CircularProgress component, which replaces the old one built with the (abandoned) react-native-progress-circle micro-library. The new component is built with the reanimated library and doesn't generate errors with the new 0.72 RN version, unlike the current implementation.

List of changes proposed in this pull request

  • Add the new CircularProgress component
  • Rename CieReadingCardAnimation into CieCardReadingAnimation for consistency with other CieCard… related files
  • Remove react-native-progress-circle dependency

Preview

cie-card-reading-animation.mov

Related PR

How to test

Try to access the app with CIE auth flow

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Jun 21, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-328] Add the new CircularProgress component + Remove react-native-progress-circle dependency chore(Cross): [IOAPPX-328] Add the new CircularProgress component + Remove react-native-progress-circle dependency Jun 21, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jun 21, 2024

Affected stories

  • ⚙️ IOAPPX-328: Rimozione di react-native-progress-circle con componente ad hoc
    subtask of

Generated by 🚫 dangerJS against 2f7f50e

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.

Project coverage is 49.55%. Comparing base (4f204b4) to head (2bbe163).
Report is 209 commits behind head on master.

Current head 2bbe163 differs from pull request most recent head 2f7f50e

Please upload reports for the commit 2f7f50e to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5890      +/-   ##
==========================================
+ Coverage   48.42%   49.55%   +1.13%     
==========================================
  Files        1488     1703     +215     
  Lines       31617    33741    +2124     
  Branches     7669     8214     +545     
==========================================
+ Hits        15311    16721    +1410     
- Misses      16238    16959     +721     
+ Partials       68       61       -7     
Files Coverage Δ
...screens/authentication/cie/CieCardReaderScreen.tsx 5.94% <ø> (+0.42%) ⬆️
ts/features/design-system/core/DSLoaders.tsx 42.10% <75.00%> (-7.90%) ⬇️
ts/components/cie/CieCardReadingAnimation.tsx 6.89% <14.28%> (ø)
ts/components/ui/CircularProgress.tsx 27.27% <27.27%> (ø)

... and 793 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48abc55...2f7f50e. Read the comment docs.

@dmnplb dmnplb marked this pull request as ready for review June 21, 2024 13:43
@dmnplb dmnplb requested a review from a team as a code owner June 21, 2024 13:43
Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀. Tested on both Android and iOS

🤖 🍏
default.mov
default.mov

@dmnplb dmnplb merged commit 2bc832f into master Jun 25, 2024
11 checks passed
@dmnplb dmnplb deleted the IOAPPX-328-remove-progress-circle-dependency branch June 25, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants