-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOCOM-1417] Security suggestions bottom sheet, new messages' home #5895
Conversation
Since the PR has a dependency on another one, the changes related to the sec.sug. bottom sheet are in:
|
Affected stories
|
Thanks, I think it's perfect! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5895 +/- ##
==========================================
+ Coverage 48.42% 49.36% +0.93%
==========================================
Files 1488 1722 +234
Lines 31617 34157 +2540
Branches 7669 8256 +587
==========================================
+ Hits 15311 16862 +1551
- Misses 16238 17232 +994
+ Partials 68 63 -5
... and 832 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
# Conflicts: # ts/features/messages/screens/MessagesHomeScreen.tsx
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on both android and iOS
Short description
This PR adds the security suggestions bottom sheet to the new messages' home.
iOS
Android
SecuritySuggestion_ios.mp4
SecuritySuggestion_android.mov
List of changes proposed in this pull request
useSecuritySuggestionBottomSheet
wrapped inside aSecuritySuggestions
component (linked inMessagesHomeScreen
) in order to avoid multiple messages section re-renderingsHow to test
Using the io-dev-api-server, make sure to enable fast-login. Since the new messages' home requires two flags to be active and the security suggestions bottom sheet does not appear a second time, fastest way to test is to add the following code to
LandingScreen.tsx
: