Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-1417] Security suggestions bottom sheet, new messages' home #5895

Merged
merged 18 commits into from
Jul 2, 2024

Conversation

Vangaorth
Copy link
Contributor

⚠️ This PR depends on #5894 ⚠️

Short description

This PR adds the security suggestions bottom sheet to the new messages' home.

Security Suggestions
iOS
Security Suggestions
Android
SecuritySuggestion_ios.mp4
SecuritySuggestion_android.mov

List of changes proposed in this pull request

  • useSecuritySuggestionBottomSheet wrapped inside a SecuritySuggestions component (linked in MessagesHomeScreen) in order to avoid multiple messages section re-renderings

How to test

Using the io-dev-api-server, make sure to enable fast-login. Since the new messages' home requires two flags to be active and the security suggestions bottom sheet does not appear a second time, fastest way to test is to add the following code to LandingScreen.tsx:

  const { setExperimental } = useIOExperimentalDesign();
  ..
  React.useEffect(
   () => () => {
      ..
      AsyncStorage.setItem(DS_PERSISTENCE_KEY, JSON.stringify(true)).finally(
        () => {
          dispatch(
            preferencesDesignSystemSetEnabled({ isDesignSystemEnabled: true })
          );
          setExperimental(true);
          dispatch(
            preferencesNewHomeSectionSetEnabled({
              isNewHomeSectionEnabled: true
            })
          );
        }
      );
    },
    []
  );

@Vangaorth
Copy link
Contributor Author

Vangaorth commented Jun 24, 2024

@shadowsheep1 and @Ladirico

Since the PR has a dependency on another one, the changes related to the sec.sug. bottom sheet are in:

  • /ts/features/messages/components/Home/SecuritySuggestions.tsx
  • /ts/features/messages/screens/MessagesHomeScreen.tsx

@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-1417] Security suggestions bottom sheet, new messages' home feat: [IOCOM-1417] Security suggestions bottom sheet, new messages' home Jun 24, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jun 24, 2024

Affected stories

  • 🌟 IOCOM-1417: [App] Inserire il bottom-sheet sui consigli di sicurezza (già realizzato da A&I) nella Home messaggi
    subtask of
    • IOCOM-810: Adottare il nuovo design system nella Home dei messaggi

Generated by 🚫 dangerJS against 8e6ed87

@shadowsheep1
Copy link
Member

@shadowsheep1 and @Ladirico

Since the PR has a dependency on another one, the changes related to the sec.sug. bottom sheet are in:

* `/ts/features/messages/components/Home/SecuritySuggestions.tsx`

* `/ts/features/messages/screens/MessagesHomeScreen.tsx`

Thanks, I think it's perfect!

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.36%. Comparing base (4f204b4) to head (8e6ed87).
Report is 234 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5895      +/-   ##
==========================================
+ Coverage   48.42%   49.36%   +0.93%     
==========================================
  Files        1488     1722     +234     
  Lines       31617    34157    +2540     
  Branches     7669     8256     +587     
==========================================
+ Hits        15311    16862    +1551     
- Misses      16238    17232     +994     
+ Partials       68       63       -5     
Files Coverage Δ
...s/messages/components/Home/SecuritySuggestions.tsx 100.00% <100.00%> (ø)
...s/features/messages/screens/MessagesHomeScreen.tsx 33.33% <ø> (-20.33%) ⬇️

... and 832 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db259d...8e6ed87. Read the comment docs.

# Conflicts:
#	ts/features/messages/screens/MessagesHomeScreen.tsx
Copy link

dpulls bot commented Jun 25, 2024

🎉 All dependencies have been resolved !

Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on both android and iOS

@Vangaorth Vangaorth merged commit a09ddad into master Jul 2, 2024
13 checks passed
@Vangaorth Vangaorth deleted the IOCOM-1417-securityBS branch July 2, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants