-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOCOM-1557] New payment flow from a message's details #5899
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5899 +/- ##
==========================================
+ Coverage 48.42% 49.57% +1.15%
==========================================
Files 1488 1703 +215
Lines 31617 33748 +2131
Branches 7669 8209 +540
==========================================
+ Hits 15311 16732 +1421
- Misses 16238 16955 +717
+ Partials 68 61 -7
... and 792 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…io-app into IOCOM-1557_newPayFromMes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Considering the Jira ticket instructions to refactor the utility function by replacing it with a custom hook and removing the workaround, the flow is working as expected.
Short description
This PR adds the new payment flow when starting from a message (standard or SEND). It is triggered only if the related feature flag is active.
The payment code that handles new payment flow does not support SEND messages or new DS ones (it is compatible only with the legacy standard message). In order to meet the deadline, such code had to be duplicated and changed to support both SEND and new standard messages. It is also uncovered by automatic testing.
List of changes proposed in this pull request
ts/features/payments/checkout/tempWorkaround/pagoPaPaymentWorkaround.ts
: duplicated code to support SEND and new standard messages (the main difference is that it does not rely upon being callend inside a React Component, so not having a direct dependency upon useDispatch and useNavigation hooks)ts/features/messages/utils/index.ts
: entry point for the new flow for SEND and new standard messagests/features/messages/components/MessageDetail/PaymentButton.tsx
: entry point for the old standard messagests/features/messages/components/MessageDetail/MessageDetailsPaymentButton.tsx
ts/features/messages/components/MessageDetail/MessagePaymentItem.tsx
ts/features/pn/components/MessageFooter.tsx
How to test
Using the io-dev-api-server on this branch IOBP-698-mock-redirect-method, generate messages with payment and SEND messages with payment(s). For each combination of the new DS and the new Wallet, check that the flow work as intended. Exhaustive list of use-cases is: