Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPID-1995] Add logic to use ComposedBodyFromArray into IOScrollViewWithLargeHeader #5900

Merged
merged 10 commits into from
Jun 28, 2024

Conversation

Ladirico
Copy link
Contributor

@Ladirico Ladirico commented Jun 25, 2024

Short description

This edit has been made in order to use the logic of ComposedBodyFromArray to customize the description style into IOScrollViewWithLargeHeader component. In this PR you can find too the application example.

Example:

img

@pagopa-github-bot pagopa-github-bot changed the title [IOPID-1995] add logic to use ComposedBodyFromArray into IOScrollViewWithLargeHeader chore: [IOPID-1995] Add logic to use ComposedBodyFromArray into IOScrollViewWithLargeHeader Jun 25, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jun 25, 2024

Affected stories

  • ⚙️ IOPID-1995: [APP] Modifica del componente IOScrollViewWithLargeHeader
    subtask of
    • IOPID-1613: DS - Adeguamento componenti libreria

Generated by 🚫 dangerJS against 627f087

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.55%. Comparing base (4f204b4) to head (627f087).
Report is 228 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5900      +/-   ##
==========================================
+ Coverage   48.42%   49.55%   +1.12%     
==========================================
  Files        1488     1728     +240     
  Lines       31617    33974    +2357     
  Branches     7669     8259     +590     
==========================================
+ Hits        15311    16836    +1525     
- Misses      16238    17075     +837     
+ Partials       68       63       -5     
Files Coverage Δ
ts/screens/profile/EmailForwardingScreen.tsx 4.25% <ø> (-0.92%) ⬇️
ts/components/ui/IOScrollViewWithLargeHeader.tsx 68.18% <33.33%> (ø)

... and 834 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b1cb7...627f087. Read the comment docs.

@Ladirico Ladirico merged commit f8422d9 into master Jun 28, 2024
13 checks passed
@Ladirico Ladirico deleted the IOPID-1995-app-edit-io-scroll-view-with-large-header branch June 28, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants