Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes an issue when parsing a large header #22

Merged
merged 12 commits into from
Dec 5, 2023
Merged

Conversation

grausof
Copy link
Contributor

@grausof grausof commented Dec 5, 2023

Short description

This PR fixes an issue found with the latest version of nimbus-jose-jwt which introduced a 20k character limit on header size, see MAX_HEADER_STRING_LENGTH

Furthermore, an upgrade has been made to version 9.30.2 of com.nimbusds:nimbus-jose-jwt and the README has been updated.

How to test

Tested with the example app

@grausof grausof requested a review from a team as a code owner December 5, 2023 12:57
Copy link
Contributor

@hevelius hevelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grausof grausof merged commit cdbe17f into main Dec 5, 2023
1 of 6 checks passed
@grausof grausof deleted the fix-max-header branch December 5, 2023 15:34
LazyAfternoons added a commit to pagopa/io-app that referenced this pull request Dec 5, 2023
….0 (#5303)

## Short description
This PR updates `io-react-native-jwt` to the `1.1.0` version which fixes
an issue during the credential issuing on Android.
More on the issue in [this
PR](pagopa/io-react-native-jwt#22).

## List of changes proposed in this pull request
- Updates the dependency.

## How to test
Test the credential issuing flow on Android and it should work as
expected.

Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants