-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-737] Update io-react-native-jwt library to 1.1.0 #5303
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## bundle/it-wallet #5303 +/- ##
====================================================
+ Coverage 45.64% 46.36% +0.72%
====================================================
Files 1620 1637 +17
Lines 33457 33976 +519
Branches 8245 8237 -8
====================================================
+ Hits 15270 15754 +484
- Misses 18138 18171 +33
- Partials 49 51 +2
... and 294 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I want to reiterate that as a workaround it is fine but it does not represent the expected solution. This fix was necessary to bypass the 20k character limit when parsing the JWS header on Android device. Limit added in reference this CVE
Short description
This PR updates
io-react-native-jwt
to the1.1.0
version which fixes an issue during the credential issuing on Android.More on the issue in this PR.
List of changes proposed in this pull request
How to test
Test the credential issuing flow on Android and it should work as expected.