fix: Improve Stake Time Calculation Accuracy #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kehiy
requested changes
May 11, 2024
b00f
reviewed
May 11, 2024
| @@ -117,7 +116,7 @@ func (bc *Blockchain) calcRewardHandler(cmd command.Command, _ command.AppID, _ | |||
|
|
|||
| return cmd.SuccessfulResult("Approximately you earn %v PAC reward, with %v PAC stake 🔒 on your validator in one %s ⏰ with %s total power ⚡ of committee."+ | |||
| "\n\n> Note📝: This number is just an estimation. It will vary depending on your stake amount and total network power.", | |||
| utils.FormatNumber(reward), utils.FormatNumber(int64(stake)), time, utils.FormatNumber(int64(amount.Amount(bi.TotalPower).ToPAC()))) | |||
| utils.FormatNumber(reward), utils.FormatNumber(int64(stake)), duration, utils.FormatNumber(int64(amount.Amount(bi.TotalPower).ToPAC()))) | |||
There was a problem hiding this comment.
Why "utils.FormatNumber(int64(stake))"?
Get stake like:
stake, err := amount.FromString(args[0])
if err != nil {
return cmd.ErrorResult(err)
}
reward := stake*blocks / amount.Amount(bi.TotalPower)
Try to work with amount.Amount not int64
done |
…Rename Variable for Clarity
b00f
reviewed
May 12, 2024
|
|
||
| return cmd.SuccessfulResult("Approximately you earn %v PAC reward, with %v PAC stake 🔒 on your validator in one %s ⏰ with %s total power ⚡ of committee."+ | ||
| "\n\n> Note📝: This number is just an estimation. It will vary depending on your stake amount and total network power.", | ||
| utils.FormatNumber(reward), utils.FormatNumber(int64(stake)), time, utils.FormatNumber(int64(amount.Amount(bi.TotalPower).ToPAC()))) | ||
| utils.FormatNumber(int64(reward)), utils.FormatNumber(int64(stake)), duration, utils.FormatNumber(int64(amount.Amount(bi.TotalPower).ToPAC()))) |
There was a problem hiding this comment.
Try avoid this:
utils.FormatNumber(int64(reward)), utils.FormatNumber(int64(stake))
use amt.String()
b00f
reviewed
May 13, 2024
| @@ -8,6 +8,7 @@ import ( | |||
| "github.com/pagu-project/Pagu/client" | |||
| "github.com/pagu-project/Pagu/engine/command" | |||
| "github.com/pagu-project/Pagu/utils" | |||
| // "github.com/pagu-project/Pagu/utils" | |||
b00f
reviewed
May 13, 2024
| @@ -114,11 +115,12 @@ func (bc *Blockchain) calcRewardHandler(cmd command.Command, _ command.AppID, _ | |||
|
|
|||
| rewardInt := stake * blocks / int(amount.Amount(bi.TotalPower).ToPAC()) | |||
|
|
|||
| reward := amount.Amount(rewardInt) | |||
| // convert from nanoPac to PAC. | |||
| totalPowerInPAC := bi.TotalPower / 1_000_000_000 | |||
There was a problem hiding this comment.
@izikdepth please one time read and check amount.Amount functions.
Avoid using bare operation here.
b00f
approved these changes
May 17, 2024
b00f
approved these changes
May 23, 2024
|
@akbariandev close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Types of changes