Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve Stake Time Calculation Accuracy #119

Closed
wants to merge 18 commits into from
Closed

fix: Improve Stake Time Calculation Accuracy #119

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f70ad2e
Add version.go file to manage project versioning
izikdepth Mar 19, 2024
be43535
update cli & discord files to utilize version.go for managing project…
izikdepth Mar 19, 2024
6cebbd2
Removed xml and json tags
izikdepth Mar 19, 2024
aebda8c
Merge branch 'robopac-project:main' into main
izikdepth Mar 19, 2024
f77ba95
Merge branch 'main' of github.com:izikdepth/RoboPac
izikdepth Mar 20, 2024
5647db0
Merge branch 'main' of github.com:izikdepth/RoboPac
izikdepth Mar 22, 2024
abc9fab
Merge branch 'main' of github.com:izikdepth/RoboPac
izikdepth Mar 27, 2024
817288f
Merge branch 'main' of github.com:izikdepth/RoboPac
izikdepth Mar 31, 2024
c93d1bd
Merge branch 'main' of github.com:izikdepth/RoboPac
izikdepth Apr 6, 2024
2ad7b6e
Merge branch 'main' of github.com:izikdepth/RoboPac
izikdepth May 9, 2024
01d9adb
Merge branch 'main' of github.com:izikdepth/RoboPac
izikdepth May 10, 2024
47fb3d3
fix stake time error
izikdepth May 10, 2024
f0f2014
Merge branch 'pagu-project:main' into fix/stake-time
izikdepth May 10, 2024
3f56718
Refactor: Replace int64 with amount.Amount for Duration Handling and …
izikdepth May 11, 2024
c53c9bc
Refactor: ensure consistent use of Amount struct to format pac values
izikdepth May 12, 2024
1530750
fmt: format blockchain.go
izikdepth May 12, 2024
9ace7d7
Refactor: refactor blockchain module to use amount.Amount struct
izikdepth May 14, 2024
795943b
Merge branch 'pagu-project:main' into fix/stake-time
izikdepth May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions engine/command/blockchain/blockchain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/pagu-project/Pagu/client"
"github.com/pagu-project/Pagu/engine/command"
"github.com/pagu-project/Pagu/utils"
// "github.com/pagu-project/Pagu/utils"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line.

)

const (
Expand Down Expand Up @@ -114,11 +115,12 @@ func (bc *Blockchain) calcRewardHandler(cmd command.Command, _ command.AppID, _

rewardInt := stake * blocks / int(amount.Amount(bi.TotalPower).ToPAC())

reward := amount.Amount(rewardInt)
// convert from nanoPac to PAC.
totalPowerInPAC := bi.TotalPower / 1_000_000_000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izikdepth please one time read and check amount.Amount functions.
Avoid using bare operation here.


return cmd.SuccessfulResult("Approximately you earn %v PAC reward, with %v PAC stake 🔒 on your validator in one %s ⏰ with %s total power ⚡ of committee."+
"\n\n> Note📝: This number is just an estimation. It will vary depending on your stake amount and total network power.",
utils.FormatNumber(int64(reward)), utils.FormatNumber(int64(stake)), duration, utils.FormatNumber(int64(amount.Amount(bi.TotalPower).ToPAC())))
rewardInt, strconv.Itoa(stake), duration, utils.FormatNumber(totalPowerInPAC))
}

func (bc *Blockchain) calcFeeHandler(cmd command.Command, _ command.AppID, _ string, args ...string) command.CommandResult {
Expand Down
Loading