Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated outdated packages #332

Closed
wants to merge 11 commits into from

Conversation

jonhamm
Copy link

@jonhamm jonhamm commented Nov 9, 2022

All packages reported as outdated have been updated to latest versions
Default node version changed to 16.18.1

@PabloLION
Copy link
Collaborator

PabloLION commented Jan 28, 2023

@kamiazya I think we should include in v6.0.0 #347 as well and for this, we need to update the CI. Let's discuss in that issue.

@PabloLION PabloLION mentioned this pull request Jan 28, 2023
@PabloLION PabloLION self-assigned this Jan 28, 2023
Copy link
Collaborator

@PabloLION PabloLION left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only tested manually with node 19. We should add CI for more node versions. Approved to enable 'merge'.

@kamiazya
Copy link
Collaborator

ora v6 has braking change.

To incorporate this modification, the entire madge must be converted to an ESModule.

Below are some of the Errors that were occurring on TravisCI.

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /home/travis/build/pahen/madge/node_modules/ora/index.js

@PabloLION
Copy link
Collaborator

My test all passed but npm generate failed with same error message. Maybe we should consider adding generate to test?

@kamiazya
Copy link
Collaborator

@PabloLION CI fails as a result of the npm debug command, and since it does fail, it seems unnecessary to take any action on the CI side.

@PabloLION
Copy link
Collaborator

Agreed. I just saw @kamiazya updated node_js fields in .travis.yml in #342. Also, node 19 is not a LTS version so we can skip it to save some CI process and keep things as they are now.

@kamiazya
Copy link
Collaborator

This PR is CLOSED because it has many conflicts with other merged PRs.

This PR has generated a lot of discussion, and we are extremely grateful for its contribution to the project.

Thank you very maych!

@kamiazya kamiazya closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants