-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated outdated packages #332
Conversation
"dependency-tree": "^8.1.1", "detective-amd": "^4.0.1", "detective-cjs": "^4.0.0", "detective-es6": "^3.0.0", "detective-postcss": "^6.1.0", "detective-sass": "^4.0.1", "detective-scss": "^3.0.0", "detective-stylus": "^2.0.1", "detective-typescript": "^9.0.0",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only tested manually with node 19. We should add CI for more node versions. Approved to enable 'merge'.
ora v6 has braking change. To incorporate this modification, the entire madge must be converted to an ESModule. Below are some of the Errors that were occurring on TravisCI.
|
My test all passed but |
@PabloLION CI fails as a result of the npm debug command, and since it does fail, it seems unnecessary to take any action on the CI side. |
This PR is CLOSED because it has many conflicts with other merged PRs. This PR has generated a lot of discussion, and we are extremely grateful for its contribution to the project. Thank you very maych! |
All packages reported as outdated have been updated to latest versions
Default node version changed to 16.18.1