Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support Node.js EOL versions(<14) #342

Merged
merged 4 commits into from Jan 28, 2023

Conversation

kamiazya
Copy link
Collaborator

@kamiazya kamiazya commented Jan 17, 2023

Hi,

This pull request is up to the project's policy, so you are free to include it.

Node versions other than LTS are not recommended as they may be vulnerable.

This pull request explicitly states that LTS 14 or later is supported as of the current status (2023-01-18) by specifying the engines in package.json.

I also modify the configuration to work with Node.js 14, 16, and 18, which are the current LTS on CircleCI.
(Unfortunately, Node 14 will be out of support in a few weeks.)

Thanks!

@kamiazya
Copy link
Collaborator Author

As mentioned in the link below, there was a bug that failed when installing Node 18 on Ubuntu 18.04 (Bionic), so I fixed it to use Ubuntu 20.04 (Focal).

https://travis-ci.community/t/the-command-npm-config-set-spin-false-failed-and-exited-with-1-during/12909/7

@pahen pahen self-requested a review January 27, 2023 14:49
@kamiazya kamiazya added this to the 6.0.0 milestone Jan 28, 2023
@kamiazya kamiazya merged commit 948cd2d into pahen:master Jan 28, 2023
@kamiazya kamiazya deleted the support-only-node-lts-versions branch January 28, 2023 01:59
This was referenced Jan 28, 2023
@kamiazya kamiazya mentioned this pull request Jan 29, 2023
@kamiazya kamiazya mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants