-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scale_info feauture #175
Conversation
- UInt - B0 - B1
- Greater - Less - Equal - PInt - NInt - ATerm - TArr
@paholg can you force running CI test please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update CHANGELOG.md as well.
Cargo.toml
Outdated
@@ -1,7 +1,7 @@ | |||
[package] | |||
name = "typenum" | |||
build = "build/main.rs" | |||
version = "1.14.0" # remember to update html_root_url | |||
version = "1.14.1" # remember to update html_root_url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a feature addition, it should bump to 1.15. Also note the comment here; the version needs to be bumped in lib.rs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paholg can you force running CI test please? (again)
@@ -17,6 +17,9 @@ | |||
categories = ["no-std"] | |||
edition = "2018" | |||
|
|||
[dependencies] | |||
scale-info = { version = "1.0", default-features = false, optional=true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scale-info = { version = "1.0", default-features = false, optional=true } | |
scale-info = { version = "1.0", default-features = false, optional = true } |
@@ -7,6 +7,10 @@ against this Rust version. | |||
|
|||
### Unreleased | |||
|
|||
### 1.15.0 (2021-12-06) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### 1.15.0 (2021-12-06) | |
### 1.15.0 (2021-12-25) |
@@ -7,6 +7,10 @@ against this Rust version. | |||
|
|||
### Unreleased | |||
|
|||
### 1.15.0 (2021-12-06) | |||
- [added] New feauture `scale_info` for using inside [Substrate](https://github.com/paritytech/substrate.git)-based runtimes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [added] New feauture `scale_info` for using inside [Substrate](https://github.com/paritytech/substrate.git)-based runtimes | |
- [added] New feature `scale_info` for using inside [Substrate](https://github.com/paritytech/substrate.git)-based runtimes |
Description
This pr adds new feature
scale_info
that addsscale_info::TypeInfo
derive for all structsJustification
Substrate's new Metadata introduces new restriction for runtime types: all encoded with SCALE codec types needs to be annotated with with scale_info::TypeInfo derive.
substrate-fixed trait depends on
typenum
and wildly used for building Substrate's runtimes so pr is usefull for all Substrate devs