add scale_info feauture #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 18, 2021 15:04
- UInt - B0 - B1
- Greater - Less - Equal - PInt - NInt - ATerm - TArr
|
@paholg can you force running CI test please? |
paholg
reviewed
Oct 28, 2021
Cargo.toml
Outdated
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| name = "typenum" | |||
| build = "build/main.rs" | |||
| version = "1.14.0" # remember to update html_root_url | |||
| version = "1.14.1" # remember to update html_root_url | |||
There was a problem hiding this comment.
As this is a feature addition, it should bump to 1.15. Also note the comment here; the version needs to be bumped in lib.rs as well.
There was a problem hiding this comment.
@paholg can you force running CI test please? (again)
paholg
approved these changes
Dec 26, 2021
| @@ -17,6 +17,9 @@ | |||
| categories = ["no-std"] | |||
| edition = "2018" | |||
|
|
|||
| [dependencies] | |||
| scale-info = { version = "1.0", default-features = false, optional=true } | |||
There was a problem hiding this comment.
Suggested change
| scale-info = { version = "1.0", default-features = false, optional=true } | |
| scale-info = { version = "1.0", default-features = false, optional = true } |
| @@ -7,6 +7,10 @@ against this Rust version. | |||
|
|
|||
| ### Unreleased | |||
|
|
|||
| ### 1.15.0 (2021-12-06) | |||
There was a problem hiding this comment.
Suggested change
| ### 1.15.0 (2021-12-06) | |
| ### 1.15.0 (2021-12-25) |
| @@ -7,6 +7,10 @@ against this Rust version. | |||
|
|
|||
| ### Unreleased | |||
|
|
|||
| ### 1.15.0 (2021-12-06) | |||
| - [added] New feauture `scale_info` for using inside [Substrate](https://github.com/paritytech/substrate.git)-based runtimes | |||
There was a problem hiding this comment.
Suggested change
| - [added] New feauture `scale_info` for using inside [Substrate](https://github.com/paritytech/substrate.git)-based runtimes | |
| - [added] New feature `scale_info` for using inside [Substrate](https://github.com/paritytech/substrate.git)-based runtimes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds new feature
scale_infothat addsscale_info::TypeInfoderive for all structsJustification
Substrate's new Metadata introduces new restriction for runtime types: all encoded with SCALE codec types needs to be annotated with with scale_info::TypeInfo derive.
substrate-fixed trait depends on
typenumand wildly used for building Substrate's runtimes so pr is usefull for all Substrate devs