Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flask-oauthlib has been deprecated #816

Closed
Leppunen opened this issue Apr 2, 2020 · 3 comments · Fixed by #861
Closed

flask-oauthlib has been deprecated #816

Leppunen opened this issue Apr 2, 2020 · 3 comments · Fixed by #861
Labels

Comments

@Leppunen
Copy link
Contributor

Leppunen commented Apr 2, 2020

This causes issues with the recent release of werkzeug 1.0.0 that breaks this library.

authlib is what the developer is recommending everyone to migrate to.

@RAnders00
Copy link
Contributor

Where do we use werkzeug in the project (and in a way that pulls in the new 1.0.0 version)? Don't we pin all the imported versions via requirements.txt?

@RAnders00
Copy link
Contributor

Traceback (most recent call last):
  File "/home/ruben/git/pajbot/app.py", line 20, in <module>
    pajbot.web.init(args)
  File "/home/ruben/git/pajbot/pajbot/web/__init__.py", line 35, in init
    import pajbot.web.routes
  File "/home/ruben/git/pajbot/pajbot/web/routes/__init__.py", line 3, in <module>
    import pajbot.web.routes.base
  File "/home/ruben/git/pajbot/pajbot/web/routes/base/__init__.py", line 5, in <module>
    import pajbot.web.routes.base.login
  File "/home/ruben/git/pajbot/pajbot/web/routes/base/login.py", line 9, in <module>
    from flask_oauthlib.client import OAuth
  File "/home/ruben/git/pajbot/venv/lib/python3.7/site-packages/flask_oauthlib/client.py", line 18, in <module>
    from werkzeug import url_quote, url_decode, url_encode
ImportError: cannot import name 'url_quote' from 'werkzeug' (/home/ruben/git/pajbot/venv/lib/python3.7/site-packages/werkzeug/__init__.py)

RAnders00 added a commit that referenced this issue Apr 2, 2020
RAnders00 added a commit that referenced this issue Apr 2, 2020
@RAnders00 RAnders00 added the bug label Apr 2, 2020
@pajlada pajlada closed this as completed in 229db41 Apr 5, 2020
@pajlada
Copy link
Member

pajlada commented Apr 5, 2020

Not fully fixed, just bandaged. Reopening

@pajlada pajlada reopened this Apr 5, 2020
@RAnders00 RAnders00 mentioned this issue May 9, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants