Reworked login system #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance you'd want to have a look at this as well? :D #450 |
|
That's not really login related, and does not fit into this PR at all. We can do it afterwards, and it would be just as easy to do as before this PR. |
RAnders00
added a commit
that referenced
this pull request
May 16, 2020
I forgot to commit that as part of #861
RAnders00
added a commit
that referenced
this pull request
May 16, 2020
I forgot to commit that as part of #861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login is now (imo) nicer and more maintainable
Pull request checklist:
CHANGELOG.mdwas updated, if applicable