Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable submit button on some states #125

Closed
israellevin opened this issue Oct 11, 2018 · 3 comments
Closed

Disable submit button on some states #125

israellevin opened this issue Oct 11, 2018 · 3 comments
Assignees
@DenisDemyanko
Labels
design
Projects
mobile
Milestone
1.2.7

Comments

@israellevin
Copy link

  1. In login form, the "restore account" should be disabled until a mnemonic or a seed is typed
  2. In send bul form the "send" button should be disabled until recipient and amount are filled
  3. In purchase BUL and XLM "purchase" button should be disabled until payment currency and amount are filled
  4. In profile page the "update profile" button should be disabled until some details have changed
@israellevin israellevin added this to To do in mobile via automation Oct 11, 2018
@DenisDemyanko
Copy link
Collaborator

@israellevin
How about other pages?
Should I add on these pages?

  1. Registration
  2. SMS Verification
  3. Launch Package
  4. Settings

@DenisDemyanko DenisDemyanko moved this from To do to In progress in mobile Oct 12, 2018
@israellevin
Copy link
Author

Good thinking!

  1. Yes
  2. Yes
  3. I think no, because it's a long form, and we rather jump to the missing field than have the user frustrated with the disabled button and searching for the missing field himself (or cursing and uninstalling the app)
  4. Yes, like in profile page - only enable button if changes were made

@DenisDemyanko DenisDemyanko added this to the 1.2.7 milestone Oct 16, 2018
DenisDemyanko added a commit that referenced this issue Oct 16, 2018
@DenisDemyanko
Change default servers to paket.global servers #134
Different texts f…
687ed6a 
…or QR code button in different states #124
Disable submit button on some states #125
@DenisDemyanko
Copy link
Collaborator

Added in 687ed6a4

@DenisDemyanko DenisDemyanko moved this from In progress to Needs review in mobile Oct 16, 2018
mobile automation moved this from Needs review to Done Oct 17, 2018
DenisDemyanko added a commit that referenced this issue Nov 13, 2018
@DenisDemyanko
Merge branch 'milestone-1.3.0'
7d4dfbb 
* milestone-1.3.0:
  Fix pull to refresh in packages #150 Prepare for new API error #149
  added try/catch on android
  Fix friendly service
  #rename FriendlyService
  If a server is down, the app should show a friendly, and hopefully informative message. #147
  Add events from background process #137 Use remote settings #144 Remove debug banners for events #146 Fix phrasing of error when attempting to purchase too many BULs #145
  Use remote settings #144
  #jobservice disable debug
  #event log
  #job service
  Add a welcome message after restoring or creating account #141 Add a relaxing message while waiting for account creation #140 When entering a price in BUL, automatically show price in EUR #142
  #update change log
  Add events from background process #137 Add explenatory text when choosing locations #136 Add default phone number for launcher #138 Opening address book takes too long #139
  Improve background process behaviour #135
  update change log
  Change default servers to paket.global servers #134
Different texts for QR code button in different states #124
Disable submit button on some states #125
  Replace links with buttons #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenisDemyanko DenisDemyanko

Labels
design
Projects
mobile
  
Done
Milestone
1.2.7
Development

No branches or pull requests
2 participants
@israellevin @DenisDemyanko