Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace links with buttons #90

Closed
israellevin opened this issue Sep 26, 2018 · 3 comments
Closed

Replace links with buttons #90

israellevin opened this issue Sep 26, 2018 · 3 comments
Assignees
@DenisDemyanko @AndreusExx
Labels
enhancement New feature or request
Projects
mobile
Milestone
1.2.6

Comments

@israellevin
Copy link

We have several types of links in our app, which appear with text and a heading, and they should all become buttons or icons. What I currently see is:

  1. App URL - this is a URL for the specific package within our site or even within the app itself, showing pretty and interesting information about the package
  2. PAKET URL - this is a URL for an external Stellar explorer, showing the cryptographic details of the package, of interest only to geeks
  3. Join our telegram - this opens telegram and joins our channel

Please consult with Serge regarding the design, and replace these links wherever you see them. And if you find ones I missed, please add there here in the conversation.
@israellevin israellevin added the enhancement New feature or request label Sep 26, 2018
@israellevin israellevin added this to To do in mobile via automation Sep 26, 2018
@DenisDemyanko DenisDemyanko added this to the 1.2.6 milestone Sep 26, 2018
@DenisDemyanko DenisDemyanko moved this from To do to In progress in mobile Oct 11, 2018
@DenisDemyanko
Copy link
Collaborator

Added in d0ecae7

@DenisDemyanko DenisDemyanko moved this from In progress to Needs review in mobile Oct 12, 2018
@owlen
Copy link
Contributor

owlen commented Oct 14, 2018

New buttons are better, but there is no need for the tiny title: "app url" and big button "click to open".
Just create a button with the text.
About should have three buttons:

  • Browse PAKET Website
  • Browse Application Page
  • More Settings (as it is today)

@owlen owlen moved this from Needs review to To do in mobile Oct 14, 2018
DenisDemyanko added a commit that referenced this issue Oct 16, 2018
@DenisDemyanko
Replace links with buttons #90
18a0711
@DenisDemyanko
Copy link
Collaborator

Added in 18a0711

@DenisDemyanko DenisDemyanko moved this from To do to Needs review in mobile Oct 16, 2018
DenisDemyanko added a commit that referenced this issue Nov 13, 2018
@DenisDemyanko
Merge branch 'milestone-1.3.0'
7d4dfbb 
* milestone-1.3.0:
  Fix pull to refresh in packages #150 Prepare for new API error #149
  added try/catch on android
  Fix friendly service
  #rename FriendlyService
  If a server is down, the app should show a friendly, and hopefully informative message. #147
  Add events from background process #137 Use remote settings #144 Remove debug banners for events #146 Fix phrasing of error when attempting to purchase too many BULs #145
  Use remote settings #144
  #jobservice disable debug
  #event log
  #job service
  Add a welcome message after restoring or creating account #141 Add a relaxing message while waiting for account creation #140 When entering a price in BUL, automatically show price in EUR #142
  #update change log
  Add events from background process #137 Add explenatory text when choosing locations #136 Add default phone number for launcher #138 Opening address book takes too long #139
  Improve background process behaviour #135
  update change log
  Change default servers to paket.global servers #134
Different texts for QR code button in different states #124
Disable submit button on some states #125
  Replace links with buttons #90
mobile automation moved this from Needs review to Done Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenisDemyanko DenisDemyanko

@AndreusExx AndreusExx

Labels
enhancement New feature or request
Projects
mobile
  
Done
Milestone
1.2.6
Development

No branches or pull requests
4 participants
@israellevin @owlen @DenisDemyanko @AndreusExx