Skip to content

Commit

Permalink
adds npm-install, tini, and npm-start to npm group
Browse files Browse the repository at this point in the history
This npm-install does not set a launch process.
See paketo-buildpacks/npm-install#109

Co-authored-by: Arjun Sreedharan <asreedharan@vmware.com>
  • Loading branch information
joshzarrabi and arjun024 committed Sep 10, 2020
1 parent a9c63d5 commit 7ae658e
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 4 deletions.
12 changes: 10 additions & 2 deletions buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,16 @@ api = "0.2"
version = "0.1.1"

[[order.group]]
id = "paketo-buildpacks/npm"
version = "0.1.81"
id = "paketo-buildpacks/npm-install"
version = "0.2.0"

[[order.group]]
id = "paketo-buildpacks/tini"
version = "0.0.2"

[[order.group]]
id = "paketo-buildpacks/npm-start"
version = "0.0.1"

[[order]]

Expand Down
4 changes: 3 additions & 1 deletion integration/npm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ func testNPM(t *testing.T, context spec.G, it spec.S) {
Expect(err).NotTo(HaveOccurred())

Expect(logs).To(ContainLines(ContainSubstring("Node Engine Buildpack")))
Expect(logs).To(ContainLines(ContainSubstring("NPM Buildpack")))
Expect(logs).To(ContainLines(ContainSubstring("NPM Install Buildpack")))
Expect(logs).To(ContainLines(ContainSubstring("Tini Buildpack")))
Expect(logs).To(ContainLines(ContainSubstring("Npm Start Buildpack")))

container, err = docker.Container.Run.Execute(image.ID)
Expect(err).NotTo(HaveOccurred())
Expand Down
5 changes: 4 additions & 1 deletion package.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
image = "gcr.io/paketo-buildpacks/node-start:0.0.6"

[[dependencies]]
image = "gcr.io/paketo-buildpacks/npm:0.1.81"
image = "gcr.io/paketo-buildpacks/npm-install:0.2.0"

[[dependencies]]
image = "gcr.io/paketo-buildpacks/npm-start:0.0.1"

[[dependencies]]
image = "gcr.io/paketo-buildpacks/yarn-install:0.2.0"
Expand Down

0 comments on commit 7ae658e

Please sign in to comment.