Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM Buildpack should only run "npm install" #109

Closed
kvedurmu opened this issue Aug 13, 2020 · 1 comment · Fixed by #127
Closed

NPM Buildpack should only run "npm install" #109

kvedurmu opened this issue Aug 13, 2020 · 1 comment · Fixed by #127

Comments

@kvedurmu
Copy link
Member

As per the Node.js re-architecture RFC, once paketo-buildpacks/nodejs#212 is implemented, we should rename this buildpack to Paketo NPM Install Buildpack and update the buildpack to only run npm install. After this is complete, Language family ordering will look like:

[[order]]

  [[order.group]]
    id = "paketo-buildpacks/node-engine"

  [[order.group]]
    id = "paketo-buildpacks/yarn"

  [[order.group]]
    id = "paketo-buildpacks/yarn-install"

  [[order.group]]
    id = "paketo-buildpacks/tini"

  [[order.group]]
    id = "paketo-buildpacks/yarn-start"

[[order]]

  [[order.group]]
    id = "paketo-buildpacks/node-engine"

  [[order.group]]
    id = "paketo-buildpacks/npm-install"

  [[order.group]]
    id = "paketo-buildpacks/tini"

  [[order.group]]
    id = "paketo-buildpacks/npm-start"

[[order]]

  [[order.group]]
    id = "paketo-buildpacks/node-engine"

  [[order.group]]
    id = "paketo-buildpacks/node-start"
@kvedurmu kvedurmu mentioned this issue Aug 13, 2020
Closed
@arjun024 arjun024 mentioned this issue Sep 9, 2020
Merged
joshzarrabi added a commit to paketo-buildpacks/nodejs that referenced this issue Sep 10, 2020
@joshzarrabi @arjun024
adds npm-install, tini, and npm-start to npm group
7ae658e 
This npm-install does not set a launch process.
See paketo-buildpacks/npm-install#109

Co-authored-by: Arjun Sreedharan <asreedharan@vmware.com>
@joshzarrabi joshzarrabi mentioned this issue Sep 10, 2020
Merged
@arjun024
Copy link
Member

Due to RFC 0002, tini has been removed from the group. See paketo-buildpacks/nodejs#241

arjun024 added a commit to paketo-buildpacks/nodejs that referenced this issue Sep 14, 2020
@joshzarrabi @arjun024
adds npm-install, tini, and npm-start to npm group
a004855 
This npm-install does not set a launch process.
See paketo-buildpacks/npm-install#109

Co-authored-by: Arjun Sreedharan <asreedharan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Buildpack should only run "npm install" paketo-buildpacks/npm-install
2 participants
@arjun024 @kvedurmu