Make dependency license an interface #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Will resolve #222.
With version v0.14.1 of packit and beyond, any buildpacks that do not have a
buildpack.toml
that matches what we expect in packit,jam summarize
fails because the license field (slice of strings) is represented as as struct.This has been an issue in our language family buildpacks (https://github.com/paketo-community/rust/actions/runs/1225798554).
This change just makes the dependency license field in
cargo.Config
into a slice ofinterface
rather than a slice ofstring
. This makes the field more flexible so that commands injam
that consumecargo.Config
(such asjam summarize
) will not error out withcannot unmarshal object into Go struct field Config.metadata of type string
.This change should have no effect on buildpacks that have the
buildpack.toml
format we expect.This will be followed by a PR in
jam
to slightly modify how dependency licenses are gathered.Use Cases
Checklist