Handle No Sub-Buildpacks #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebhale
added
semver:patch
nebhale
force-pushed
the
sub-buildpacks
branch
4 times, most recently
from
60abb70
to
d1801c8
Compare
Previously when writing release notes, the script would attempt to iterate over any sub-buildpacks that were contained within this main buildpack. In the case where there were no sub-buildpacks, an error would be printed to the console. This error was harmless, but better to be correct. This change only iterates over the sub-buildpacks if at least one exists. Signed-off-by: Ben Hale <bhale@vmware.com>
nebhale
force-pushed
the
sub-buildpacks
branch
from
d1801c8
to
f44188d
Compare
ekcasey
approved these changes
Nov 3, 2020
This was referenced Nov 3, 2020
This was referenced Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when writing release notes, the script would attempt to iterate over any sub-buildpacks that were contained within this main buildpack. In the case where there were no sub-buildpacks, an error would be printed to the console. This error was harmless, but better to be correct. This change only iterates over the sub-buildpacks if at least one exists.
/cc @ameyer-pivotal @aemengo