Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

Fix link to yj in bionic build Dockerfile. (#130) #131

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

robdimsdale
Copy link
Member

Closes #128 ; based off #130

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

* Fix link to yj in bionic build Dockerfile.

* Update curl flags to fail fast and clearly.
@robdimsdale robdimsdale requested a review from a team as a code owner April 19, 2022 13:42
@sophiewigmore sophiewigmore merged commit 0c35322 into main Apr 19, 2022
@sophiewigmore sophiewigmore deleted the yj-fix branch April 19, 2022 14:17
@fgrehm
Copy link

fgrehm commented Apr 19, 2022

Thanks for the quick turnaround here folks! Really appreciated ❤️

@sophiewigmore @robdimsdale I'm kinda new to paketo projects' workflows but is this something that requires manual intervention for a release or will it be automagically created like at some point this week? We rebuild our builders on a weekly basis (monday mornings) so we're wondering if we should just lock our imgs to an upstream build stack tag that we know for sure will have an usable yj (to avoid breaking our devs builds) or if we can just chill and let it automatically get latest next monday.

Also, if there's anything I can do to help test things out to help with that release please LMK too! 🍻

@fgrehm fgrehm mentioned this pull request Apr 19, 2022
3 tasks
@sophiewigmore
Copy link
Member

sophiewigmore commented Apr 19, 2022

@fgrehm the change will take effect when the releases come out, but our automation doesn't allow for a release to come out unless there's a change to the packages in the image. Because of this, we're kind of at the mercy of a package update (which happen every few days usually). I'd say we can rely on a release coming out in the next week, looking at the release cadence in the past. Our automation checks for updates everyday, and will also get updated when a USN comes out for a CVE.

The next release should contain the functional yj, so you should be good to just consume the next release!

@sophiewigmore
Copy link
Member

sophiewigmore commented Apr 19, 2022

@fgrehm the good news is that I just triggered a release of the full stack and there was a package update so paketobuildpacks/build:1.3.34-full-cnb is available and looks like yj is functional!! I'll do the same for base and tiny stacks as well.

@fgrehm
Copy link

fgrehm commented Apr 19, 2022

You're awesome! Thank you very much 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yj is not working properly at times
3 participants