Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catkinizes reem_common and adds launcher for visualising the robot model #5

Closed

Conversation

bit-pirate
Copy link

This adds a groovy-devel branch which contains the catkinized reem_common stack.
I have added a launcher (plus rviz config) for visualising the robot model using RViz.
The dependency on the pr2_mechanism_model has been commented out, since that stack hasn't been catkinized yet.

@adolfo-rt
Copy link
Contributor

Hey Marcus,

Thanks for your work, this is the first catkinized REEM stack ever :-).

I can't merge the pull request into master as-is, because it would break our setup, which still relies on rosbuild. Still, I see two workarounds that would allow merging your work and make us both happy:

  • I can create a groovy branch (groovy-devel does not conform to our current naming convention) and you can make a new pull request against that branch. This alternative requires the least amount of work.
  • You could modify the pull request to allow the stack to be a rosbuild-catkin hybrid. We would then drop rosbuild support in a future time, when the official REEM ROS distro is one with proper catkin support.

What is your preference?

@bit-pirate
Copy link
Author

You are welcome! :-)

Well, I haven't done a hybrid package so far. Will PAL run parallel (rosbuild & catkin) for a while or is it more likely that you make a big jump to catkin with all ROS code in the near future. If the first is the case, it might be could considering a hybrid package. Otherwise, I would suggest to use a separate branch until PAL makes the jump.

@adolfo-rt
Copy link
Contributor

We would make the jump to catkin once we start supporting a post-Fuerte ROS distribution, but this will not take place in the near future. Still, a separate branch seems the easiest solution.

@bit-pirate
Copy link
Author

Okay, let me know, when you have set up the groovy-devel branch and I will make a new pull request.

@adolfo-rt
Copy link
Contributor

Created!

@bit-pirate
Copy link
Author

Just issued the new pull request.

@bit-pirate bit-pirate closed this Jun 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants