Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-defined timescale in time_bins() #19

Closed
willgearty opened this issue Jul 18, 2022 · 1 comment · Fixed by #72
Closed

User-defined timescale in time_bins() #19

willgearty opened this issue Jul 18, 2022 · 1 comment · Fixed by #72
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@willgearty
Copy link
Collaborator

It would be great to give more flexibility to the user to which timescale is being used for time_bins() (like axis_geo()). This could include incorporating other timescales through deeptime::getTimeScale() or by letting the user supply their own dataframe. I imagine this would be most useful for the equal-length binning aspect of time_bins().

@LewisAJones
Copy link
Collaborator

@ChristopherDavidDean we should try to get this implemented for version 1.1.0. I don't think it will be too difficult tbh.

LewisAJones added a commit that referenced this issue Dec 23, 2022
@LewisAJones LewisAJones linked a pull request Dec 23, 2022 that will close this issue
LewisAJones added a commit that referenced this issue Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants