Add PhyloPic base R legend #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willgearty
requested changes
Dec 21, 2023
There was a problem hiding this comment.
This is great, thanks @LewisAJones! I noticed that the location of the phylopics seems a little off, especially when the legend is on the left side of the plot. I also made some suggestions that I think would make the function more user-friendly.
|
Thanks for the quick review and constructive feedback @willgearty! I’ve gone ahead and implemented your changes. Let me know if you see any final tweaks needed! |
willgearty
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Thanks for the quick changes @LewisAJones! Everything looks good to me, great job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the function
add_phylopic_legend(). It allows users to add a legend using PhyloPic silhouettes to base R. The function makes use oflegend()andadd_phylopic_base()to do most of the groundwork. I’ve tried to make the function as flexible as possible while also trying to maintain ease of use. Note, I’ve forced some arguments fromlegend()to be ignored to avoid any undesirable behaviour.Closes #83.