Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Numeric Input] Fix focus-hoarding on IE11 #704

Closed
cmslewis opened this issue Feb 17, 2017 · 0 comments
Closed

[Numeric Input] Fix focus-hoarding on IE11 #704

cmslewis opened this issue Feb 17, 2017 · 0 comments
Assignees
@cmslewis
Labels
P1 Package: core Type: bug

Comments

@cmslewis
Copy link
Contributor

cmslewis commented Feb 17, 2017 •
edited

Bug report

  • Package version(s): v1.8.0
  • Browser and OS versions: IE11

Steps to reproduce

  1. Type something in a numeric input in the docs.
  2. Try to focus on something else (via click or Tab)

Actual behavior

You can't.
2017-02-17 14 46 15

Expected behavior

You can.
@cmslewis cmslewis self-assigned this Feb 17, 2017
@cmslewis cmslewis mentioned this issue Feb 18, 2017
Merged
4 tasks
cmslewis added a commit that referenced this issue Feb 18, 2017
@cmslewis
Try to fix #704 focus hoarding on IE11
741f286
cmslewis added a commit that referenced this issue Feb 20, 2017
@cmslewis
[Numeric Input] Add "selectAllOnFocus" and "selectAllOnIncrement" pro…
2bf21bf 
…ps (#705)

* Add selectAllOnFocus prop

* Add default prop for selectAllOnFocus

* Add selectAllOnIncrement prop

* Remove 'If , the cursor is placed at the end of the text' language

* Add example switches for selectAllOnFocus and selectAllOnIncrement

* Add 'If ...' message for selectAllOnIncrement again

* Add 'If ...' message for selectAllOnIncrement again

* Fix overrides/partial error that for some reason wasn't causing the build to fail

* Add unit tests, including some disabled ones

* Delete unused variable in unit tests

* Fix/skip broken tests in Phantom

* Try to fix #704 focus hoarding on IE11

* Remove the declaration that cursor will move to end of text
- B/c doesn't work in IE11, and
- Test doesn't pass in FF
@cmslewis cmslewis mentioned this issue Feb 22, 2017
Closed
@giladgray giladgray mentioned this issue Feb 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmslewis cmslewis

Labels
P1 Package: core Type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmslewis @adidahiya