[Numeric Input] Add "selectAllOnFocus" and "selectAllOnIncrement" props #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llorca
approved these changes
Feb 18, 2017
- B/c doesn't work in IE11, and - Test doesn't pass in FF
giladgray
reviewed
Feb 20, 2017
| @@ -107,6 +119,8 @@ export class NumericInput extends AbstractComponent<HTMLInputProps & INumericInp | |||
| buttonPosition: Position.RIGHT, | |||
| majorStepSize: 10, | |||
| minorStepSize: 0.1, | |||
| selectAllOnFocus: false, | |||
| selectAllOnIncrement: false, | |||
There was a problem hiding this comment.
why default these features off? they use to be enabled all the time.
There was a problem hiding this comment.
Just following EditableText's example when I copied the prop description over, but I do prefer having them on. Will switch.
There was a problem hiding this comment.
Actually, both EditableText and TimePicker expose a selectAllOnFocus prop, and both default the prop to false. I'd prefer to stay consistent with their APIs by defaulting NumericInput's selectAllOn* props to false too. Thoughts @giladgray?
There was a problem hiding this comment.
+1 on consistency, therefore I think it should be false. If necessary, follow up with a PR that changes this default behavior to true across the board
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #703 · Fixes #704
Checklist
NumericInput's props tablesChanges proposed in this pull request:
selectAllOnFocusprop.selectAllOnIncrementprop.karma-unit-coretest in FF)Reviewers should focus on:
EditableText, the unit tests I added forselectAllOnFocusdon't work in Phantom. Thus, the tests are included but disabled. Is there a way to get them working? If not, should I keep them or delete them?Screenshot