-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table] Create a playground where you can toggle all features in one place #1154
Conversation
@@ -6,25 +6,131 @@ | |||
<link rel="stylesheet" type="text/css" href="dist/perf.css"> | |||
<style> | |||
body { | |||
padding: 20px 20px; | |||
position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time to improve the build setup for this preview page methinks (future PR).
margin-bottom: 7px; | ||
} | ||
|
||
.tbl-select-label .pt-select { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbl-
is my little custom namespace.
); | ||
|
||
// TODO: Pull these from @blueprintjs/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to do this in this PR. Wasn't able to wrangle it after a few seconds of poking, so I copied+pasted to unblock myself.
Better stylesPreview: documentation | table |
overall looks good! can we throw in a focus style manager "only show outline on tabs" somewhere? |
Insert with random text takes a shockingly long time, but other than that looks great! Excited to use this going forward |
The focus cell doesn't move around :( |
|
Focus style controlPreview: documentation | table |
@adidahiya I added a focus-style control. |
Sync focus style on componentDidMount tooPreview: documentation | table |
Merging because this only affects internal Table preview, and I have other stuff I want to do with it today. |
Changes proposed in this pull request:
perf.html
spreadsheet example.Table
Playground. (The term "playground" is a little overloaded now; feel free to suggest something else, though note that string doesn't appear in this PR.)Reviewers should focus on:
Table
bugs and/or weirdnesses from this already!resizeByTallest...
, reorganize the table preview pages).[table docs url]/perf.html
.Screenshot